linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Stefan Roese <sr@denx.de>
Cc: linuxppc-dev@ozlabs.org, Timur Tabi <timur@freescale.com>,
	Sean MacLennan <smaclennan@pikatech.com>
Subject: Re: [PATCH] powerpc: add of_find_next_property andof_get_aliased_index
Date: Thu, 3 Jul 2008 09:33:13 -0400	[thread overview]
Message-ID: <20080703093313.478e6773@zod.rchland.ibm.com> (raw)
In-Reply-To: <200806262041.12275.sr@denx.de>

On Thu, 26 Jun 2008 20:41:12 +0200
Stefan Roese <sr@denx.de> wrote:

> On Thursday 26 June 2008, Sean MacLennan wrote:
> > > Well, there's a lot of disagreement on this subject.  Not only do we
> > > not agree on a method of enumerating devices, a lot of people have a
> > > problem with the concept of enumerating them in the first place!
> >
> > An interesting point is that I enforced an index in the i2c-ibm_iic
> > driver with no disagreement at all ;)
> 
> You have been lucky I suppose. :)
> 
> I could easily just have used this existing "index" property for the other 4xx 
> boards, but expected NAK's for this. That and because FSL uses "cell-index" 
> is why I asked prior to sending patches.
> 
> Now I have no idea how to support I2C on the other 4xx boards. Perhaps Josh 
> could advise how this should be done?

As David said elsewhere, cell-index is fine for figuring out how to
access the CPM registers, etc.  But it's not good for enumerating
across the whole system.

For I2C specifically, I think Sean already has a patch to switch the
4xx driver to not use the numbered functions, which eliminates the need
for the enumeration all together.  That seems like the right approach
to me.

josh

  parent reply	other threads:[~2008-07-03 13:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-25 20:05 [PATCH] powerpc: add of_find_next_property and of_get_aliased_index Timur Tabi
2008-06-25 20:22 ` Segher Boessenkool
2008-06-25 20:27   ` Timur Tabi
2008-06-25 23:35     ` Segher Boessenkool
2008-06-26 15:12       ` Timur Tabi
2008-06-26 15:51         ` Stefan Roese
2008-06-26 15:55           ` Timur Tabi
2008-06-26 18:27             ` [PATCH] powerpc: add of_find_next_property andof_get_aliased_index Sean MacLennan
2008-06-26 18:29               ` Timur Tabi
2008-06-26 18:41               ` Stefan Roese
2008-06-27  1:30                 ` David Gibson
2008-07-03 13:33                 ` Josh Boyer [this message]
2008-07-03 13:43                   ` Stefan Roese
2008-06-25 23:51 ` [PATCH] powerpc: add of_find_next_property and of_get_aliased_index Josh Boyer
2008-06-26 10:57 ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080703093313.478e6773@zod.rchland.ibm.com \
    --to=jwboyer@linux.vnet.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=smaclennan@pikatech.com \
    --cc=sr@denx.de \
    --cc=timur@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).