From: Grant Likely <grant.likely@secretlab.ca>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: liam.girdwood@wolfsonmicro.com, alsa-devel@alsa-project.org,
broonie@opensource.wolfsonmicro.com, timur@freescale.com,
linuxppc-dev@ozlabs.org
Subject: Re: [alsa-devel] [PATCH 2/3] ALSA SoC: Add mpc5200-psc I2S driver
Date: Thu, 3 Jul 2008 10:30:00 -0600 [thread overview]
Message-ID: <20080703163000.GI2284@secretlab.ca> (raw)
In-Reply-To: <9e4733910807020819sdb6f442q75dc7f10f9f605a5@mail.gmail.com>
On Wed, Jul 02, 2008 at 11:19:18AM -0400, Jon Smirl wrote:
> On 7/1/08, Grant Likely <grant.likely@secretlab.ca> wrote:
> > + /* Due to errata in the i2s mode; need to line up enabling
> > + * the transmitter with a transition on the frame sync
> > + * line */
> > +
> > + spin_lock_irqsave(&psc_i2s->lock, flags);
> > + /* first make sure it is low */
> > + while ((in_8(®s->ipcr_acr.ipcr) & 0x80) != 0);
>
> Could this be moved to the front of the routine, to increase parallelism?
>
> Once you detect the 0, it will be a fixed interval before the 1
> happens. Might as well overlap the computations.
>
Good point. I'll try this out and see if it remains stable. If this
gets done wrong, then left and right channels will often get swapped.
g.
next prev parent reply other threads:[~2008-07-03 16:30 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 23:53 [PATCH 1/3] ALSA SoC: Add OpenFirmware helper for matching bus and codec drivers Grant Likely
2008-07-01 23:53 ` [PATCH 2/3] ALSA SoC: Add mpc5200-psc I2S driver Grant Likely
2008-07-02 10:34 ` [alsa-devel] " Liam Girdwood
2008-07-02 13:51 ` Jon Smirl
2008-07-03 16:28 ` Grant Likely
2008-07-04 11:03 ` Timur Tabi
2008-07-04 14:41 ` Grant Likely
2008-07-05 1:28 ` David Gibson
2008-07-02 15:19 ` Jon Smirl
2008-07-03 16:30 ` Grant Likely [this message]
2008-07-06 17:56 ` Jon Smirl
2008-07-07 10:59 ` Mark Brown
2008-07-07 13:23 ` Jon Smirl
2008-07-12 6:26 ` Grant Likely
2008-07-07 16:32 ` Jon Smirl
2008-07-12 6:30 ` Grant Likely
2008-07-09 8:22 ` new to sound world
2008-07-01 23:53 ` [PATCH 3/3] ALSA SoC: Add Texas Instruments TLV320AIC26 codec driver Grant Likely
2008-07-02 10:48 ` [alsa-devel] " Liam Girdwood
2008-07-12 6:00 ` Grant Likely
2008-07-12 17:36 ` Mark Brown
2008-07-12 18:13 ` Grant Likely
2008-07-17 23:31 ` Grant Likely
2008-07-18 9:58 ` Mark Brown
2008-07-18 16:14 ` Grant Likely
2008-07-02 13:52 ` Jon Smirl
2008-07-02 16:08 ` Liam Girdwood
2008-07-04 20:49 ` Mark Brown
2008-07-04 23:44 ` Grant Likely
2008-07-02 9:50 ` [alsa-devel] [PATCH 1/3] ALSA SoC: Add OpenFirmware helper for matching bus and codec drivers Takashi Iwai
2008-07-02 15:48 ` Grant Likely
2008-07-02 15:57 ` Liam Girdwood
2008-07-02 13:50 ` Jon Smirl
2008-07-02 15:27 ` Jon Smirl
2008-07-03 16:33 ` Grant Likely
2008-07-04 11:05 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080703163000.GI2284@secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jonsmirl@gmail.com \
--cc=liam.girdwood@wolfsonmicro.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).