From: Robert Jennings <rcj@linux.vnet.ibm.com>
To: paulus@samba.org
Cc: Brian King <brking@linux.vnet.ibm.com>,
linuxppc-dev@ozlabs.org,
David Darrington <ddarring@linux.vnet.ibm.com>
Subject: [PATCH 08/16 v3] powerpc: Do not probe PCI buses or eBus devices if CMO is enabled
Date: Fri, 4 Jul 2008 07:54:18 -0500 [thread overview]
Message-ID: <20080704125418.GK1310@linux.vnet.ibm.com> (raw)
In-Reply-To: <20080704124449.GA1310@linux.vnet.ibm.com>
=46rom: Brian King <brking@linux.vnet.ibm.com>
The Cooperative Memory Overcommit (CMO) on System p does not currently
support native PCI devices or eBus devices when enabled. Prevent
PCI bus probe and eBus device probe if the feature is enabled.
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: Robert Jennings <rcj@linux.vnet.ibm.com>
---
arch/powerpc/kernel/ibmebus.c | 6 ++++++
arch/powerpc/platforms/pseries/setup.c | 4 ++++
2 files changed, 10 insertions(+)
Index: b/arch/powerpc/kernel/ibmebus.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- a/arch/powerpc/kernel/ibmebus.c
+++ b/arch/powerpc/kernel/ibmebus.c
@@ -45,6 +45,7 @@
#include <linux/of_platform.h>
#include <asm/ibmebus.h>
#include <asm/abs_addr.h>
+#include <asm/firmware.h>
=20
static struct device ibmebus_bus_device =3D { /* fake "parent" device */
.bus_id =3D "ibmebus",
@@ -332,6 +333,11 @@ static int __init ibmebus_bus_init(void)
{
int err;
=20
+ if (firmware_has_feature(FW_FEATURE_CMO)) {
+ printk(KERN_WARNING "Not probing eBus since CMO is enabled\n");
+ return 0;
+ }
+
printk(KERN_INFO "IBM eBus Device Driver\n");
=20
err =3D of_bus_type_init(&ibmebus_bus_type, "ibmebus");
Index: b/arch/powerpc/platforms/pseries/setup.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- a/arch/powerpc/platforms/pseries/setup.c
+++ b/arch/powerpc/platforms/pseries/setup.c
@@ -539,6 +539,10 @@ static void pseries_shared_idle_sleep(vo
=20
static int pSeries_pci_probe_mode(struct pci_bus *bus)
{
+ if (firmware_has_feature(FW_FEATURE_CMO)) {
+ dev_warn(&bus->dev, "Not probing PCI bus since CMO is enabled\n");
+ return PCI_PROBE_NONE;
+ }
if (firmware_has_feature(FW_FEATURE_LPAR))
return PCI_PROBE_DEVTREE;
return PCI_PROBE_NORMAL;
next prev parent reply other threads:[~2008-07-04 12:54 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-04 12:44 [PATCH 00/16 v3] powerpc: pSeries Cooperative Memory Overcommitment support Robert Jennings
2008-07-04 12:51 ` [PATCH 01/16 v3] powerpc: Remove extraneous error reporting for hcall failures in lparcfg Robert Jennings
2008-07-22 3:34 ` Paul Mackerras
2008-07-04 12:51 ` [PATCH 02/16 v3] powerpc: Split processor entitlement retrieval and gathering to helper routines Robert Jennings
2008-07-22 18:53 ` Nathan Fontenot
2008-07-04 12:51 ` [PATCH 03/16 v3] powerpc: Add memory entitlement capabilities to /proc/ppc64/lparcfg Robert Jennings
2008-07-22 18:55 ` Nathan Fontenot
2008-07-04 12:52 ` [PATCH 04/16 v3] powerpc: Split retrieval of processor entitlement data into a helper routine Robert Jennings
2008-07-22 5:54 ` Paul Mackerras
2008-07-22 18:49 ` Nathan Fontenot
2008-07-22 18:56 ` Nathan Fontenot
2008-07-04 12:52 ` [PATCH 05/16 v3] powerpc: Enable CMO feature during platform setup Robert Jennings
2008-07-04 12:52 ` Robert Jennings
2008-07-04 12:52 ` [PATCH 06/16 v3] powerpc: Utilities to set firmware page state Robert Jennings
2008-07-04 12:53 ` Robert Jennings
2008-07-04 12:53 ` [PATCH 07/16 v3] powerpc: Add collaborative memory manager Robert Jennings
2008-07-22 4:53 ` Paul Mackerras
2008-07-04 12:54 ` Robert Jennings [this message]
2008-07-14 21:35 ` [PATCH 08/16 v3] powerpc: Do not probe PCI buses or eBus devices if CMO is enabled Brian King
2008-07-04 12:54 ` [PATCH 09/16 v3] powerpc: Add CMO paging statistics Robert Jennings
2008-07-04 12:54 ` [PATCH 10/16 v3] powerpc: iommu enablement for CMO Robert Jennings
2008-07-05 17:51 ` Olof Johansson
2008-07-08 20:48 ` [PATCH 10/16 v3] [v2] " Robert Jennings
2008-07-22 5:04 ` Paul Mackerras
2008-07-22 13:30 ` Robert Jennings
2008-07-22 4:57 ` [PATCH 10/16 v3] " Paul Mackerras
2008-07-22 13:28 ` Robert Jennings
2008-07-04 12:55 ` [PATCH 11/16 v3] powerpc: vio bus support " Robert Jennings
2008-07-04 12:55 ` [PATCH 12/16 v3] powerpc: Verify CMO memory entitlement updates with virtual I/O Robert Jennings
2008-07-04 12:55 ` [PATCH 13/16 v3] ibmveth: Automatically enable larger rx buffer pools for larger mtu Robert Jennings
2008-07-04 12:56 ` [PATCH 14/16 v3] ibmveth: enable driver for CMO Robert Jennings
2008-07-08 20:38 ` [PATCH 14/16 v3] [v2] " Robert Jennings
2008-07-04 12:56 ` [PATCH 15/16 v3] ibmvscsi: driver enablement " Robert Jennings
2008-07-07 14:34 ` Brian King
2008-07-08 17:41 ` Robert Jennings
2008-07-08 20:35 ` [PATCH 15/16 v3] [v2] " Robert Jennings
2008-07-10 13:43 ` Brian King
2008-07-04 12:57 ` [PATCH 16/16 v3] powerpc: Update arch vector to indicate support " Robert Jennings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080704125418.GK1310@linux.vnet.ibm.com \
--to=rcj@linux.vnet.ibm.com \
--cc=brking@linux.vnet.ibm.com \
--cc=ddarring@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).