From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Sonny Rao <sonnyrao@us.ibm.com>
Cc: jschopp@us.ibm.com, Nathan, sonnyrao@linux.vnet.ibm.com,
linuxppc-dev@ozlabs.org, paulus@samba.org, Lynch <ntl@pobox.com>
Subject: Re: [PATCHv3] Power5,Power6 BSR driver
Date: Tue, 8 Jul 2008 14:52:34 +1000 [thread overview]
Message-ID: <20080708145234.998082ad.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20080708025812.GC15821@us.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 711 bytes --]
Hi Sonny,
On Mon, 7 Jul 2008 21:58:12 -0500 Sonny Rao <sonnyrao@us.ibm.com> wrote:
>
> +static int bsr_create_devs(struct device_node *bn)
> +{
> + cur->bsr_device = device_create(bsr_class, NULL,
> + cur->bsr_dev,
> + cur->bsr_name);
> + if (!cur->bsr_device) {
> + printk(KERN_ERR "device_create failed for %s\n",
> + cur->bsr_name);
> + cdev_del(&cur->bsr_cdev);
> + goto out_err;
> + }
> + dev_set_drvdata(cur->bsr_device, cur);
device_create() is being removed in 2.6.27 because the above introduces a
race, use device_create_drvdata() instead.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-07-08 4:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-16 18:53 [PATCH] Power5,Power6 BSR driver jschopp
2008-06-17 22:39 ` Nathan Lynch
2008-06-17 22:44 ` Sonny Rao
2008-06-18 6:51 ` Sonny Rao
2008-07-07 4:59 ` Benjamin Herrenschmidt
2008-07-07 21:17 ` Sonny Rao
2008-07-07 22:26 ` Benjamin Herrenschmidt
2008-07-08 2:58 ` [PATCHv3] " Sonny Rao
2008-07-08 4:52 ` Stephen Rothwell [this message]
2008-07-08 5:45 ` [PATCHv4] " Sonny Rao
2008-06-18 6:53 ` [PATCH] " Sonny Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080708145234.998082ad.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=jschopp@us.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=ntl@pobox.com \
--cc=paulus@samba.org \
--cc=sonnyrao@linux.vnet.ibm.com \
--cc=sonnyrao@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).