linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Chandru <chandru@in.ibm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linuxppc-dev@ozlabs.org, kexec@lists.infradead.org
Subject: Re: [PATCH 1/4] kdump : add support for ibm, dynamic-reconfiguration-memory for kexec/kdump
Date: Tue, 8 Jul 2008 16:28:07 +0530	[thread overview]
Message-ID: <200807081628.07843.chandru@in.ibm.com> (raw)
In-Reply-To: <20080708113646.13836635.sfr@canb.auug.org.au>

Thanks for the review comments. I will change to 'snprintf' at all the places  
and remove the unnecessary casts.

On Tuesday 08 July 2008 07:06:46 Stephen Rothwell wrote:
> Hi Chandru,
>
> On Tue, 8 Jul 2008 00:14:24 +0530 Chandru <chandru@in.ibm.com> wrote:
> > +		if (usm != NULL) {
> > +			ranges = (len >> 2) / (n_mem_addr_cells +
>
>                                  ^^^^^^^^^^
> len / sizeof(u32) ?

ranges is made to count the number of linux,usable-memory properties in the 
device tree.  It's acting as a counter here.  So the expression in the patch 
is fine. 

Thanks,
Chandru

  reply	other threads:[~2008-07-08 11:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-07 18:44 [PATCH 1/4] kdump : add support for ibm, dynamic-reconfiguration-memory for kexec/kdump Chandru
2008-07-08  1:36 ` Stephen Rothwell
2008-07-08 10:58   ` Chandru [this message]
2008-07-08  1:56 ` Michael Neuling
2008-07-10 22:27 ` [PATCH 1/4] kdump : add support for ibm, dynamic-reconfiguration-memory for kexec/kdump Nathan Fontenot
2008-07-11 11:09   ` Chandru
2008-07-11 13:49     ` [PATCH 1/4][V2] powerpc : add support for linux, usable-memory properties for drconf memory Chandru
2008-07-22  9:01       ` Chandru
2008-07-22  9:12         ` Benjamin Herrenschmidt
2008-07-22  9:16         ` Paul Mackerras
2008-07-25 16:51           ` Chandru

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807081628.07843.chandru@in.ibm.com \
    --to=chandru@in.ibm.com \
    --cc=kexec@lists.infradead.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).