linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@ozlabs.org
Subject: Re: linux-next: kbuild tree build failure
Date: Tue, 8 Jul 2008 23:19:30 +0200	[thread overview]
Message-ID: <20080708211930.GA16897@uranus.ravnborg.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0807071424240.6791@localhost.localdomain>

Hi Roman.

I thought a bit more about this.

> I should have gone through all archs to test this, sorry about that.
> Luckily it's only powerpc that uses 64bit values. I would prefer to 
> standardize on 32bit values, as it doesn't really make sense to expect 
> from the user to input full 64bit values and it's easy to generate the 
> full value in a header.

We use Kconfig for a mixture of user editable values and fixed
configuration values.
And I agree that asking the user to input a 64 bit number is not usefull.

But keeping support for 64 bit values is what I would consider
expected functionality.
So removing support for 64 bit is not good IMO.

> This would also ease on any portability issues 
> (kconfig is compiled with the host compiler not the target compiler).

We use strtol() in a few places in symbol.c already where we do an
implicit conversion to int. Why did this not cause us problems before?

Is it because these code paths are only triggered when we deal with ranges?
If so we could 'fix' strdup_type() to not use strto{,u}l() so it
is 64 bit clean and we are back to old behaviour.

	Sam

  parent reply	other threads:[~2008-07-08 21:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-07  8:40 linux-next: kbuild tree build failure Stephen Rothwell
2008-07-07 12:51 ` Sam Ravnborg
2008-07-07 13:08   ` Stephen Rothwell
2008-07-07 16:13 ` Roman Zippel
2008-07-07 21:01   ` Sam Ravnborg
2008-07-07 23:36   ` Michael Ellerman
2008-07-08  2:55     ` Roman Zippel
2008-07-10  0:51       ` Michael Ellerman
2008-07-10 14:59         ` Roman Zippel
2008-07-14 16:53           ` Milton Miller
2008-07-08 21:19   ` Sam Ravnborg [this message]
2008-07-10 14:52     ` Roman Zippel
2008-07-25  4:13 ` Stephen Rothwell
2008-07-26 10:06   ` Sam Ravnborg
2008-07-26 12:40     ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2008-07-12 22:32 Milton Miller
2008-07-12 23:21 ` Roman Zippel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080708211930.GA16897@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=sfr@canb.auug.org.au \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).