linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Gerhard Pircher" <gerhard_pircher@gmx.net>
To: Takashi Iwai <tiwai@suse.de>, benh@kernel.crashing.org
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 0/3] ALSA fixes for non-coherent ppc32
Date: Wed, 09 Jul 2008 10:31:11 +0200	[thread overview]
Message-ID: <20080709083111.44860@gmx.net> (raw)
In-Reply-To: <s5h1w2vc9js.wl%tiwai@suse.de>

Hi,

-------- Original-Nachricht --------
> Datum: Wed, 18 Jun 2008 12:38:31 +0200
> Von: Takashi Iwai <tiwai@suse.de>
> An: benh@kernel.crashing.org
> CC: linuxppc-dev@ozlabs.org, cjg@cruxppc.org
> Betreff: [PATCH 0/3] ALSA fixes for non-coherent ppc32

> Hi,
> 
> I've tried to renew the fixes of ALSA issues about non-coherent DMA
> memories.  The last patch worked for SG-buffers somehow but would
> result in a problem if many pages are allocated because of
> dma_alloc_coherent() handling.  Now, I chose a more simpler
> workaround: the SG-buffers are handled as simple continuous buffers.
> 
> This time I split the patches to several parts.  The first patch
> contains a very lazy dma_mmap_coherent() implementation for ppc32.
> The next patch adds the call of dma_mmap_coherent() for the default
> mmap of ALSA PCM.  And the last one is to add the conversion of
> SG-buffer handling as above.
> 
> The patches are created against the latest ALSA tree, and the last
> patch won't be applicable fully to 2.6.26-rc6.  But, it's only for
> snd-hda-intel and there is no PPC32 hardware supporting this, AFAIK.
> So just ignore the reject.
> 
> The patches are found also on my git tree, dma-fix branch of
>     git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git
> 
> Any comments and test reports are appreciated, especially about
> dma_mmap_coherent() addition.
I know this answer comes a little bit late, but my PPC machine was not
working for two weeks due to a hardware failure. I tested the patch on
2.6.26-rc9 and it seems to work fine so far with my emu10k soundcard.
I just had to add "#include <linux/dma-mapping.h>" to pcm_native.c.
Otherwise it wouldn't compile.

Thanks!

regards,

Gerhard

-- 
Psssst! Schon das coole Video vom GMX MultiMessenger gesehen?
Der Eine für Alle: http://www.gmx.net/de/go/messenger03

  parent reply	other threads:[~2008-07-09  8:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-18 10:38 [PATCH 0/3] ALSA fixes for non-coherent ppc32 Takashi Iwai
2008-06-18 10:40 ` [PATCH 1/3] ppc: Add dma_mmap_coherent() for PPC32 Takashi Iwai
2008-06-18 10:41 ` [PATCH 2/3] ALSA: Fix mapping of DMA buffers Takashi Iwai
2008-06-18 10:42 ` [PATCH 3/3] ALSA: Fix SG-buffer DMA with non-coherent architectures Takashi Iwai
2008-07-09  8:31 ` Gerhard Pircher [this message]
2008-07-09  8:55   ` [PATCH 0/3] ALSA fixes for non-coherent ppc32 Benjamin Herrenschmidt
2008-07-09 17:31     ` Takashi Iwai
2008-07-09 20:06       ` Benjamin Herrenschmidt
2008-07-09 17:27   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080709083111.44860@gmx.net \
    --to=gerhard_pircher@gmx.net \
    --cc=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).