From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <davej@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [66.187.233.31])
	by ozlabs.org (Postfix) with ESMTP id F31FEDE41F
	for <linuxppc-dev@ozlabs.org>; Thu, 17 Jul 2008 08:05:10 +1000 (EST)
Date: Wed, 16 Jul 2008 17:57:45 -0400
From: Dave Jones <davej@redhat.com>
To: Scott Wood <scottwood@freescale.com>
Subject: Re: [PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS_ENET
Message-ID: <20080716215745.GA17093@redhat.com>
References: <Pine.LNX.4.64.0807160838520.14127@blarg.am.freescale.net>
	<20080716214722.GA6251@ld0162-tx32.am.freescale.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <20080716214722.GA6251@ld0162-tx32.am.freescale.net>
Cc: linuxppc-dev@ozlabs.org, akpm@linux-foundation.org,
	torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/options/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>

On Wed, Jul 16, 2008 at 04:47:23PM -0500, Scott Wood wrote:
 > On Wed, Jul 16, 2008 at 08:39:12AM -0500, Kumar Gala wrote:
 > > If we don't enable FS_ENET we get build issues:
 > > 
 > > arch/powerpc/platforms/built-in.o: In function `ep8248e_mdio_probe':
 > > arch/powerpc/platforms/82xx/ep8248e.c:129: undefined reference to `alloc_mdio_bitbang'
 > > arch/powerpc/platforms/82xx/ep8248e.c:143: undefined reference to `mdiobus_register'
 > 
 > How is this possible?  CONFIG_EP8248E selects CONFIG_MDIO_BITBANG.

If CONFIG_PHYLIB=m however, that doesn't make any difference, because
vmlinuz is trying to use a symbol which now lives in a module.

	Dave

-- 
http://www.codemonkey.org.uk