* [2.6 patch] powerpc/boot/Makefile: change spaces to tabs
@ 2008-07-17 18:18 Adrian Bunk
2008-07-18 1:47 ` David Gibson
2008-07-21 0:59 ` Benjamin Herrenschmidt
0 siblings, 2 replies; 3+ messages in thread
From: Adrian Bunk @ 2008-07-17 18:18 UTC (permalink / raw)
To: David Gibson, Paul Mackerras, benh; +Cc: linuxppc-dev
For C code spaces versus tabs is just a religious issue,
but for Makefiles it actually matters.
This patch fixes he following errors:
/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/powerpc/boot/Makefile:166: *** missing separator. Stop.
/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/powerpc/boot/Makefile:171: *** missing separator. Stop.
Since this was inside an ifdef DTC_GENPARSER it was not a problem unless
someone wanted to regenerate the shipped generated files.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
arch/powerpc/boot/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/arch/powerpc/boot/Makefile
+++ b/arch/powerpc/boot/Makefile
@@ -163,12 +163,12 @@ quiet_cmd_flex = FLEX $@
cmd_flex = $(FLEX) -o$@ $<; cp $@ $@_shipped
$(obj)/dtc-src/dtc-parser.tab.c: $(src)/dtc-src/dtc-parser.y FORCE
- $(call if_changed,bison)
+ $(call if_changed,bison)
$(obj)/dtc-src/dtc-parser.tab.h: $(obj)/dtc-src/dtc-parser.tab.c
$(obj)/dtc-src/dtc-lexer.lex.c: $(src)/dtc-src/dtc-lexer.l FORCE
- $(call if_changed,flex)
+ $(call if_changed,flex)
endif
#############
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [2.6 patch] powerpc/boot/Makefile: change spaces to tabs
2008-07-17 18:18 [2.6 patch] powerpc/boot/Makefile: change spaces to tabs Adrian Bunk
@ 2008-07-18 1:47 ` David Gibson
2008-07-21 0:59 ` Benjamin Herrenschmidt
1 sibling, 0 replies; 3+ messages in thread
From: David Gibson @ 2008-07-18 1:47 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Paul Mackerras, linuxppc-dev
On Thu, Jul 17, 2008 at 09:18:54PM +0300, Adrian Bunk wrote:
> For C code spaces versus tabs is just a religious issue,
> but for Makefiles it actually matters.
>
> This patch fixes he following errors:
> /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/powerpc/boot/Makefile:166: *** missing separator. Stop.
> /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/powerpc/boot/Makefile:171: *** missing separator. Stop.
>
> Since this was inside an ifdef DTC_GENPARSER it was not a problem unless
> someone wanted to regenerate the shipped generated files.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Oops, embarrasing mistake there.
Acked-by: David Gibson <david@gibson.dropbear.id.au>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] powerpc/boot/Makefile: change spaces to tabs
2008-07-17 18:18 [2.6 patch] powerpc/boot/Makefile: change spaces to tabs Adrian Bunk
2008-07-18 1:47 ` David Gibson
@ 2008-07-21 0:59 ` Benjamin Herrenschmidt
1 sibling, 0 replies; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2008-07-21 0:59 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linuxppc-dev, Paul Mackerras, David Gibson
On Thu, 2008-07-17 at 21:18 +0300, Adrian Bunk wrote:
> For C code spaces versus tabs is just a religious issue,
> but for Makefiles it actually matters.
>
> This patch fixes he following errors:
> /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/powerpc/boot/Makefile:166: *** missing separator. Stop.
> /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/powerpc/boot/Makefile:171: *** missing separator. Stop.
>
> Since this was inside an ifdef DTC_GENPARSER it was not a problem unless
> someone wanted to regenerate the shipped generated files.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
And that too :-)
Cheers,
Ben.
> ---
>
> arch/powerpc/boot/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/arch/powerpc/boot/Makefile
> +++ b/arch/powerpc/boot/Makefile
> @@ -163,12 +163,12 @@ quiet_cmd_flex = FLEX $@
> cmd_flex = $(FLEX) -o$@ $<; cp $@ $@_shipped
>
> $(obj)/dtc-src/dtc-parser.tab.c: $(src)/dtc-src/dtc-parser.y FORCE
> - $(call if_changed,bison)
> + $(call if_changed,bison)
>
> $(obj)/dtc-src/dtc-parser.tab.h: $(obj)/dtc-src/dtc-parser.tab.c
>
> $(obj)/dtc-src/dtc-lexer.lex.c: $(src)/dtc-src/dtc-lexer.l FORCE
> - $(call if_changed,flex)
> + $(call if_changed,flex)
> endif
>
> #############
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-07-21 0:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-17 18:18 [2.6 patch] powerpc/boot/Makefile: change spaces to tabs Adrian Bunk
2008-07-18 1:47 ` David Gibson
2008-07-21 0:59 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).