From: David Miller <davem@davemloft.net>
To: smaclennan@pikatech.com
Cc: linuxppc-dev@ozlabs.org
Subject: Re: Networkl problems with lastest kernel....
Date: Mon, 21 Jul 2008 09:31:10 -0700 (PDT) [thread overview]
Message-ID: <20080721.093110.141511905.davem@davemloft.net> (raw)
In-Reply-To: <20080721121829.28faffab@lappy.seanm.ca>
From: Sean MacLennan <smaclennan@pikatech.com>
Date: Mon, 21 Jul 2008 12:18:29 -0400
> I just did a git pull of Linus' kernel. It seems to be mainly network
> changes... and I get the following oops. Anybody else seeing this?
>
> I really don't have time to look at the problem right now, maybe
> tonight.
If I had a penny for every driver with broken TX queue handling...
Please try this patch, thanks:
diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c
index 2e720f2..4e01d29 100644
--- a/drivers/net/ibm_newemac/core.c
+++ b/drivers/net/ibm_newemac/core.c
@@ -1157,6 +1157,7 @@ static int emac_open(struct net_device *ndev)
mal_enable_rx_channel(dev->mal, dev->mal_rx_chan);
emac_tx_enable(dev);
emac_rx_enable(dev);
+ netif_start_queue(dev);
emac_netif_start(dev);
mutex_unlock(&dev->link_lock);
next prev parent reply other threads:[~2008-07-21 16:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 16:18 Networkl problems with lastest kernel Sean MacLennan
2008-07-21 16:31 ` David Miller [this message]
2008-07-21 17:05 ` Sean MacLennan
2008-07-21 17:16 ` David Miller
2008-07-21 17:37 ` Sean MacLennan
2008-07-21 23:59 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080721.093110.141511905.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=smaclennan@pikatech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).