LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Subject: Re: [3/5] replace CONFIG_POWER4 by CONFIG_PPC64
Date: Mon, 21 Jul 2008 11:40:38 +0200	[thread overview]
Message-ID: <200807211140.38926.arnd@arndb.de> (raw)
In-Reply-To: <200807210845.20778.marvin24@gmx.de>

On Monday 21 July 2008, Marvin wrote:
> diff --git a/arch/powerpc/mm/ppc_mmu_32.c b/arch/powerpc/mm/ppc_mmu_32.c
> index c53145f..c3509c8 100644
> --- a/arch/powerpc/mm/ppc_mmu_32.c
> +++ b/arch/powerpc/mm/ppc_mmu_32.c
> @@ -74,7 +74,7 @@ unsigned long p_mapped_by_bats(phys_addr_t pa)
> =A0
> =A0unsigned long __init mmu_mapin_ram(void)
> =A0{
> -#ifdef CONFIG_POWER4
> +#ifdef CONFIG_PPC64
> =A0=A0=A0=A0=A0=A0=A0=A0return 0;
> =A0#else
> =A0=A0=A0=A0=A0=A0=A0=A0unsigned long tot, bl, done;

ppc_mmu_32 is 32-bit only, so you can kill this #ifdef.

> diff --git a/include/asm-powerpc/cputable.h b/include/asm-powerpc/cputabl=
e.h
> index 0ef9abc..97fdbaf 100644
> --- a/include/asm-powerpc/cputable.h
> +++ b/include/asm-powerpc/cputable.h
> @@ -257,7 +257,7 @@ extern void do_feature_fixups(unsigned long value, vo=
id=20
> *fixup_start,
>  #endif
> =20
>  #define CLASSIC_PPC (!defined(CONFIG_8xx) && !defined(CONFIG_4xx) && \
> -		     !defined(CONFIG_POWER4) && !defined(CONFIG_BOOKE))
> +		     !defined(CONFIG_PPC64) && !defined(CONFIG_BOOKE))
> =20

This would be more logical in the opposite way:

#define CLASSIC_PPC (defined(CONFIG_PPC32) && !defined(CONFIG_8xx)
		     && !defined(CONFIG_4xx) && !defined(CONFIG_BOOKE))

	Arnd <><

      reply	other threads:[~2008-07-21  9:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-21  6:45 [3/5] replace CONFIG_POWER4 by CONFIG_PPC64 Marvin
2008-07-21  9:40 ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807211140.38926.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox