From: David Miller <davem@davemloft.net>
To: jonsmirl@gmail.com
Cc: davem@redhat.com, Linuxppc-dev@ozlabs.org, netdev@vger.kernel.org
Subject: Re: netif_schedule and mpc5200_fec
Date: Tue, 22 Jul 2008 16:07:18 -0700 (PDT) [thread overview]
Message-ID: <20080722.160718.122532549.davem@davemloft.net> (raw)
In-Reply-To: <9e4733910807221554j451019a0sa711541e97fbf0aa@mail.gmail.com>
From: "Jon Smirl" <jonsmirl@gmail.com>
Date: Tue, 22 Jul 2008 18:54:18 -0400
> On 7/22/08, David Miller <davem@davemloft.net> wrote:
> > From: "Jon Smirl" <jonsmirl@gmail.com>
> > Date: Tue, 22 Jul 2008 17:03:32 -0400
> >
> >
> > > On 7/22/08, Jon Smirl <jonsmirl@gmail.com> wrote:
> > > > I just updated to linus/master and mpc5200_fec won't boot.
> > >
> > > It does boot, but this badness looks like it is coming from this
> > > patch. I don't know enough about networking to debug it.
> >
> >
> > I just applied the following patch from Anton Vorontsov which
> > will fix this.
>
> I applied this piece and still have the same error.
There are no calls to functions in mpc52xx_fec_adjust_link that
can lead to __netif_schedule() any more.
Therefore I can't see how your backtrace is even possible.
Please double check that you've really applied the patch
and that mpc52xx_fec_adjust_link lacks any calls to
netif_*_queue() and *netif_schedule().
Thanks.
next prev parent reply other threads:[~2008-07-22 23:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 19:47 netif_schedule and mpc5200_fec Jon Smirl
2008-07-22 21:03 ` Jon Smirl
2008-07-22 21:11 ` David Miller
2008-07-22 22:42 ` David Miller
2008-07-22 22:54 ` Jon Smirl
2008-07-22 23:07 ` David Miller [this message]
2008-07-22 23:33 ` Jon Smirl
2008-07-22 23:36 ` David Miller
2008-07-23 4:57 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080722.160718.122532549.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Linuxppc-dev@ozlabs.org \
--cc=davem@redhat.com \
--cc=jonsmirl@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).