linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-project.org@rakim.wolfsonmicro.main,
	linuxppc-dev@ozlabs.org, timur@freescale.com,
	liam.girdwood@wolfsonmicro.com
Subject: Re: [PATCH 1/3] ASoC: Make OpenFirmware helper include file conditional
Date: Tue, 22 Jul 2008 17:24:52 -0400	[thread overview]
Message-ID: <20080722212452.GD12412@secretlab.ca> (raw)
In-Reply-To: <1216727589-19544-1-git-send-email-broonie@opensource.wolfsonmicro.com>

On Tue, Jul 22, 2008 at 12:53:07PM +0100, Mark Brown wrote:
> The OpenFirmware API headers don't build on all platforms so ensure
> that they are not included unless they are being used.
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

Acked-by: Grant Likely <grant.likely@secretlab.ca>

I actually fixed this in my tree, but I forgot to roll it into the patch
before I emailed it.  Thanks.

g.

> ---
>  include/sound/soc-of-simple.h |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/include/sound/soc-of-simple.h b/include/sound/soc-of-simple.h
> index 696fc51..a064e19 100644
> --- a/include/sound/soc-of-simple.h
> +++ b/include/sound/soc-of-simple.h
> @@ -7,6 +7,8 @@
>  #ifndef _INCLUDE_SOC_OF_H_
>  #define _INCLUDE_SOC_OF_H_
>  
> +#if defined(CONFIG_SND_SOC_OF_SIMPLE) || defined(CONFIG_SND_SOC_OF_SIMPLE_MODULE)
> +
>  #include <linux/of.h>
>  #include <sound/soc.h>
>  
> @@ -18,4 +20,6 @@ int of_snd_soc_register_platform(struct snd_soc_platform *platform,
>  				 struct device_node *node,
>  				 struct snd_soc_dai *cpu_dai);
>  
> +#endif
> +
>  #endif /* _INCLUDE_SOC_OF_H_ */
> -- 
> 1.5.6.3
> 

      parent reply	other threads:[~2008-07-22 21:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-22  6:58 [PATCH v3 0/3] ALSA SoC: MPC5200 audio driver Grant Likely
2008-07-22  9:26 ` [alsa-devel] " Mark Brown
2008-07-22 13:38   ` Jon Smirl
2008-07-22 14:10     ` Mark Brown
2008-07-22 14:52       ` Jon Smirl
2008-07-22 15:14         ` Timur Tabi
2008-07-22 18:39         ` Mark Brown
2008-07-22 21:26   ` Grant Likely
2008-07-22 11:52 ` Mark Brown
2008-07-22 11:53   ` [PATCH 1/3] ASoC: Make OpenFirmware helper include file conditional Mark Brown
2008-07-22 11:53     ` [PATCH 2/3] ASoC: Export DAI and codec for TLV320AIC26 Mark Brown
2008-07-22 11:53       ` [PATCH 3/3] ASoC: Staticise keyclick dev_attr in tlv320aic26 Mark Brown
2008-07-22 21:26         ` Grant Likely
2008-07-22 21:25       ` [PATCH 2/3] ASoC: Export DAI and codec for TLV320AIC26 Grant Likely
2008-07-22 21:24     ` Grant Likely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080722212452.GD12412@secretlab.ca \
    --to=grant.likely@secretlab.ca \
    --cc=alsa-project.org@rakim.wolfsonmicro.main \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=liam.girdwood@wolfsonmicro.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=timur@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).