From: Grant Likely <grant.likely@secretlab.ca>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-project.org@rakim.wolfsonmicro.main,
linuxppc-dev@ozlabs.org, timur@freescale.com,
liam.girdwood@wolfsonmicro.com
Subject: Re: [PATCH 2/3] ASoC: Export DAI and codec for TLV320AIC26
Date: Tue, 22 Jul 2008 17:25:37 -0400 [thread overview]
Message-ID: <20080722212537.GE12412@secretlab.ca> (raw)
In-Reply-To: <1216727589-19544-2-git-send-email-broonie@opensource.wolfsonmicro.com>
On Tue, Jul 22, 2008 at 12:53:08PM +0100, Mark Brown wrote:
> This fixes sparse warnings and allows non-OpenFirmware systems to attempt
> to bind to the device.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
> ---
> sound/soc/codecs/tlv320aic26.c | 1 +
> sound/soc/codecs/tlv320aic26.h | 3 +++
> 2 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/codecs/tlv320aic26.c b/sound/soc/codecs/tlv320aic26.c
> index 4621fda..73b7027 100644
> --- a/sound/soc/codecs/tlv320aic26.c
> +++ b/sound/soc/codecs/tlv320aic26.c
> @@ -383,6 +383,7 @@ struct snd_soc_codec_device aic26_soc_codec_dev = {
> .probe = aic26_probe,
> .remove = aic26_remove,
> };
> +EXPORT_SYMBOL_GPL(aic26_soc_codec_dev);
>
> /* ---------------------------------------------------------------------
> * SPI device portion of driver: sysfs files for debugging
> diff --git a/sound/soc/codecs/tlv320aic26.h b/sound/soc/codecs/tlv320aic26.h
> index 62b1f22..786ba16 100644
> --- a/sound/soc/codecs/tlv320aic26.h
> +++ b/sound/soc/codecs/tlv320aic26.h
> @@ -90,4 +90,7 @@ enum aic26_wlen {
> AIC26_WLEN_32 = 3 << 10,
> };
>
> +extern struct snd_soc_dai aic26_dai;
> +extern struct snd_soc_codec_device aic26_soc_codec_dev;
> +
> #endif /* _TLV320AIC16_H_ */
> --
> 1.5.6.3
>
next prev parent reply other threads:[~2008-07-22 21:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 6:58 [PATCH v3 0/3] ALSA SoC: MPC5200 audio driver Grant Likely
2008-07-22 9:26 ` [alsa-devel] " Mark Brown
2008-07-22 13:38 ` Jon Smirl
2008-07-22 14:10 ` Mark Brown
2008-07-22 14:52 ` Jon Smirl
2008-07-22 15:14 ` Timur Tabi
2008-07-22 18:39 ` Mark Brown
2008-07-22 21:26 ` Grant Likely
2008-07-22 11:52 ` Mark Brown
2008-07-22 11:53 ` [PATCH 1/3] ASoC: Make OpenFirmware helper include file conditional Mark Brown
2008-07-22 11:53 ` [PATCH 2/3] ASoC: Export DAI and codec for TLV320AIC26 Mark Brown
2008-07-22 11:53 ` [PATCH 3/3] ASoC: Staticise keyclick dev_attr in tlv320aic26 Mark Brown
2008-07-22 21:26 ` Grant Likely
2008-07-22 21:25 ` Grant Likely [this message]
2008-07-22 21:24 ` [PATCH 1/3] ASoC: Make OpenFirmware helper include file conditional Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080722212537.GE12412@secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=alsa-project.org@rakim.wolfsonmicro.main \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=liam.girdwood@wolfsonmicro.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).