From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: David Brownell <david-b@pacbell.net>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Kumar Gala <kumar.gala@freescale.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: latest tree build failure -- cpm uart & gpio
Date: Wed, 23 Jul 2008 02:26:34 +0400 [thread overview]
Message-ID: <20080722222634.GA4427@polina.dev.rtsoft.ru> (raw)
In-Reply-To: <1216764309.11027.211.camel@pasglop>
On Wed, Jul 23, 2008 at 08:05:09AM +1000, Benjamin Herrenschmidt wrote:
> On Tue, 2008-07-22 at 18:53 +0400, Anton Vorontsov wrote:
> > On Tue, Jul 22, 2008 at 08:54:16AM -0500, Kumar Gala wrote:
> > > can someone look at the following compile failure in linus's tree. I'm
> > > guessing part of this has to do with Alan's tty changes (and might
> > > already be addressed?).
> > >
> > > include/asm-generic/gpio.h:131: error: implicit declaration of function
> > > 'gpio_get_value'
> > > include/asm-generic/gpio.h:137: error: implicit declaration of function
> > > 'gpio_set_value'
> >
> > I think this patch should help:
> >
> > [OF] of_gpio: should use new <linux/gpio.h> header
> > http://patchwork.ozlabs.org/linuxppc/patch?id=18750
> >
> > David, can you please Ack it? See Benjamin's mail:
> > http://ozlabs.org/pipermail/linuxppc-dev/2008-July/060109.html
> >
>
> Hrm.. I though I had that one in my latest batch. In fact, I just
> checked and it got merged.
Ah, great. So the issue should be fixed already... I just pulled the
Linus' tree, and it is there indeed.
Thanks,
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
prev parent reply other threads:[~2008-07-22 22:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 13:54 latest tree build failure -- cpm uart & gpio Kumar Gala
2008-07-22 13:52 ` Alan Cox
2008-07-22 14:53 ` Anton Vorontsov
2008-07-22 19:33 ` David Brownell
2008-07-22 20:48 ` Anton Vorontsov
2008-07-22 22:05 ` Benjamin Herrenschmidt
2008-07-22 22:26 ` Anton Vorontsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080722222634.GA4427@polina.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=benh@kernel.crashing.org \
--cc=david-b@pacbell.net \
--cc=kumar.gala@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).