From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: linuxppc-dev@ozlabs.org, alsa-devel@alsa-project.org
Subject: Re: [alsa-devel] [PATCH 2/2] Allow a custom ASOC machine driver with soc-of-simple
Date: Wed, 23 Jul 2008 11:53:37 +0100 [thread overview]
Message-ID: <20080723105334.GC8377@sirena.org.uk> (raw)
In-Reply-To: <20080722235351.11648.56387.stgit@terra>
On Tue, Jul 22, 2008 at 07:53:51PM -0400, Jon Smirl wrote:
> Allow a custom ASOC machine driver with soc-of-simple
As with the clocking configuration: this looks fine from an ASoC point
of view but please fix the checkpatch warnings. However...
> /* Only register the device if both the codec and platform have
> * been registered */
> - if ((!of_soc->device.codec_data) || (!of_soc->platform_node))
> + if ((!of_soc->device.codec_data) || (!of_soc->platform_node) || !machine_name)
> return;
...this doesn't just allow a custom machine driver, it requires that
something configures at least the machine name. That's not a problem
from the ASoC point of view but possibly from the PowerPC side?
next prev parent reply other threads:[~2008-07-23 10:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 23:53 [PATCH 1/2] Support internal I2S clock sources on MPC5200 Jon Smirl
2008-07-22 23:53 ` [PATCH 2/2] Allow a custom ASOC machine driver with soc-of-simple Jon Smirl
2008-07-23 5:30 ` Stephen Rothwell
2008-07-23 10:53 ` Mark Brown [this message]
2008-07-23 14:09 ` [alsa-devel] " Jon Smirl
2008-07-23 15:14 ` Mark Brown
2008-07-23 15:16 ` Jon Smirl
2008-07-23 15:36 ` Mark Brown
2008-07-27 1:14 ` Grant Likely
2008-07-24 6:20 ` filling dummy struct snd_dma_buffer dinesh
2008-07-27 1:12 ` [PATCH 2/2] Allow a custom ASOC machine driver with soc-of-simple Grant Likely
2008-07-27 4:44 ` Jon Smirl
2008-07-27 5:29 ` Grant Likely
2008-07-27 14:07 ` Jon Smirl
2008-07-23 10:36 ` [alsa-devel] [PATCH 1/2] Support internal I2S clock sources on MPC5200 Mark Brown
2008-07-27 2:05 ` Grant Likely
2008-07-27 4:48 ` Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080723105334.GC8377@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jonsmirl@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).