From: Ingo Molnar <mingo@elte.hu>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Jeff Garzik <jgarzik@pobox.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Michael Brown <mbrown@fensystems.co.uk>
Subject: Re: sfx.c driver build failure
Date: Fri, 25 Jul 2008 09:32:25 +0200 [thread overview]
Message-ID: <20080725073225.GB21824@elte.hu> (raw)
In-Reply-To: <20080725171715.9287c823.sfr@canb.auug.org.au>
* Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> On Fri, 25 Jul 2008 16:15:59 +1000 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >
> > The sfx driver (which happens to be part of some of our test configs)
> > fails to build in current Linus tree on powerpc with this error:
> >
> > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c: In function ‘efx_probe_interrupts’:
> > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c:845: error: lvalue required as unary ‘&’ operand
>
> Commit 695a6b456307455a10059512208e8ed0d376ecd3 "topology: work around
> topology_core_siblings() breakage" in linux-next (from the cpus4096
> tree) comments out the offending lines ... With the comment "the
> topology API is a mess right now".
there's a patch from Mike Travis that solves it all from grounds up and
which approach has the ack of Rusty as well, but it's not fully tested
through yet - i will get to it later today.
Ingo
next prev parent reply other threads:[~2008-07-25 7:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-25 6:15 sfx.c driver build failure Benjamin Herrenschmidt
2008-07-25 7:17 ` Stephen Rothwell
2008-07-25 7:32 ` Ingo Molnar [this message]
2008-07-25 7:35 ` Michael Brown
2008-07-25 7:50 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080725073225.GB21824@elte.hu \
--to=mingo@elte.hu \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mbrown@fensystems.co.uk \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).