From: Chandru <chandru@in.ibm.com>
To: Paul Mackerras <paulus@samba.org>
Cc: Michael Neuling <mikey@neuling.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/4][V2] powerpc : add support for linux, usable-memory properties for drconf memory
Date: Fri, 25 Jul 2008 22:21:18 +0530 [thread overview]
Message-ID: <200807252221.19389.chandru@in.ibm.com> (raw)
In-Reply-To: <18565.42340.817405.289271@cargo.ozlabs.ibm.com>
On Tuesday 22 July 2008 14:46:20 Paul Mackerras wrote:
> Chandru writes:
>
> > Scan for linux,usable-memory properties in case of dynamic reconfiguration
> > memory . Support for kexec/kdump.
> >
> > Signed-off-by: Chandru Siddalingappa <chandru@in.ibm.com>
>
> Could we *please* have a more comprehensive patch description that
> that? Something which will help people coming along in two (or five
> or ten) years time to understand what problem exists in the code, how
> this patch solves it, and why this approach was chosen over any
> alternative approaches?
>
> Thanks,
> Paul.
>
Another alternate approach could be to create one 'linux,usable-drconf-memory' property and add all the usable memory regions into it, in a similar fashion to ibm,dynamic-memory property. For a given lmb in ibm,dynamic-memory , a corresponding usable-memory entry could be created which will contain 1 or more of (base,size) duple. For each entry in this new 'linux,usable-drconf-memory' property, a counter within it will tell us how many (base,size) duple are available in it. Some part of the current code may get duplicated. Let me go back and check if I can work on a patch for this approach .
thx,
Chandru
prev parent reply other threads:[~2008-07-25 16:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-07 18:44 [PATCH 1/4] kdump : add support for ibm, dynamic-reconfiguration-memory for kexec/kdump Chandru
2008-07-08 1:36 ` Stephen Rothwell
2008-07-08 10:58 ` Chandru
2008-07-08 1:56 ` Michael Neuling
2008-07-10 22:27 ` [PATCH 1/4] kdump : add support for ibm, dynamic-reconfiguration-memory for kexec/kdump Nathan Fontenot
2008-07-11 11:09 ` Chandru
2008-07-11 13:49 ` [PATCH 1/4][V2] powerpc : add support for linux, usable-memory properties for drconf memory Chandru
2008-07-22 9:01 ` Chandru
2008-07-22 9:12 ` Benjamin Herrenschmidt
2008-07-22 9:16 ` Paul Mackerras
2008-07-25 16:51 ` Chandru [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807252221.19389.chandru@in.ibm.com \
--to=chandru@in.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).