[PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()

[PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()

[Stephen Rothwell]

On powerpc (allyesconfig build) we get this error:

drivers/isdn/hardware/mISDN/hfcpci.c:1991: error: implicit declaration of function 'virt_to_bus'

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/isdn/hardware/mISDN/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/isdn/hardware/mISDN/Kconfig b/drivers/isdn/hardware/mISDN/Kconfig
index 1479348..9cd5f5f 100644
--- a/drivers/isdn/hardware/mISDN/Kconfig
+++ b/drivers/isdn/hardware/mISDN/Kconfig
@@ -7,6 +7,7 @@ config MISDN_HFCPCI
 	tristate "Support for HFC PCI cards"
 	depends on MISDN
 	depends on PCI
+	depends on VIRT_TO_BUS
 	help
 	  Enable support for cards with Cologne Chip AG's
           HFC PCI chip.
-- 
1.5.6.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()

[Alan Cox]

On Mon, 28 Jul 2008 02:37:32 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> On powerpc (allyesconfig build) we get this error:
> 
> drivers/isdn/hardware/mISDN/hfcpci.c:1991: error: implicit declaration of function 'virt_to_bus'
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Can we please not merge new virt_to_bus users and instead fix the actual
code to use the right functions?

Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()

[David Miller]

From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Sun, 27 Jul 2008 18:27:09 +0100

> On Mon, 28 Jul 2008 02:37:32 +1000
> Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > On powerpc (allyesconfig build) we get this error:
> > 
> > drivers/isdn/hardware/mISDN/hfcpci.c:1991: error: implicit declaration of function 'virt_to_bus'
> > 
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> 
> Can we please not merge new virt_to_bus users and instead fix the actual
> code to use the right functions?

Yes, please.

IMHO, this driver was really rushed in and that was a huge mistake.
If it had gone through linux-next we could have tidied all of this
stuff up in a less "rushed" manner.

Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()

[Roland Dreier]

 > IMHO, this driver was really rushed in and that was a huge mistake.
 > If it had gone through linux-next we could have tidied all of this
 > stuff up in a less "rushed" manner.

??  This thread *is* about a build failure in linux-next.

 - R.

Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()

[Sam Ravnborg]

On Sun, Jul 27, 2008 at 01:33:49PM -0700, Roland Dreier wrote:
>  > IMHO, this driver was really rushed in and that was a huge mistake.
>  > If it had gone through linux-next we could have tidied all of this
>  > stuff up in a less "rushed" manner.
> 
> ??  This thread *is* about a build failure in linux-next.
mISDN are in -linus which is part of -next and Stephens point is that if
we have had mISDN in -next then this would have been fixed before hitting
-linus. Maybe Karsten should use davem as gateway as he has anyway been
so for other isdn patches lately?

	Sam

Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 723 bytes --]

Hi Sam,

On Sun, 27 Jul 2008 22:43:55 +0200 Sam Ravnborg <sam@ravnborg.org> wrote:
>
> On Sun, Jul 27, 2008 at 01:33:49PM -0700, Roland Dreier wrote:
> >  > IMHO, this driver was really rushed in and that was a huge mistake.
> >  > If it had gone through linux-next we could have tidied all of this
> >  > stuff up in a less "rushed" manner.
> > 
> > ??  This thread *is* about a build failure in linux-next.
> mISDN are in -linus which is part of -next and Stephens point is that if
> we have had mISDN in -next then this would have been fixed before hitting
> -linus.

Dave made that point, not me.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()

[David Miller]

From: Roland Dreier <rdreier@cisco.com>
Date: Sun, 27 Jul 2008 13:33:49 -0700

>  > IMHO, this driver was really rushed in and that was a huge mistake.
>  > If it had gone through linux-next we could have tidied all of this
>  > stuff up in a less "rushed" manner.
> 
> ??  This thread *is* about a build failure in linux-next.

The driver went directly into Linus's tree.

Stephen hit the build problem once he synced linux-next up with
Linus's current tree.

Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 508 bytes --]

Hi Dave,

On Sun, 27 Jul 2008 16:14:32 -0700 (PDT) David Miller <davem@davemloft.net> wrote:
>
> The driver went directly into Linus's tree.
> 
> Stephen hit the build problem once he synced linux-next up with
> Linus's current tree.

It didn't even get as far as linux-next, I was just browsing the
bloodbath that is/was Linus' tree
(http://kisskb.ellerman.id.au/kisskb/branch/3/) :-(.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

Hi Roland,

On Sun, 27 Jul 2008 13:33:49 -0700 Roland Dreier <rdreier@cisco.com> wrote:
>
>  > IMHO, this driver was really rushed in and that was a huge mistake.
>  > If it had gone through linux-next we could have tidied all of this
>  > stuff up in a less "rushed" manner.
> 
> ??  This thread *is* about a build failure in linux-next.

I noticed this in Linus' tree ... I did not mention linux-next.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()

[Christoph Hellwig]

On Sun, Jul 27, 2008 at 12:56:04PM -0700, David Miller wrote:
> Yes, please.
> 
> IMHO, this driver was really rushed in and that was a huge mistake.
> If it had gone through linux-next we could have tidied all of this
> stuff up in a less "rushed" manner.

Or just reviewed in at least some way..

Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 739 bytes --]

On Sun, 27 Jul 2008 18:27:09 +0100 Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
>
> On Mon, 28 Jul 2008 02:37:32 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > On powerpc (allyesconfig build) we get this error:
> > 
> > drivers/isdn/hardware/mISDN/hfcpci.c:1991: error: implicit declaration of function 'virt_to_bus'
> > 
> > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> 
> Can we please not merge new virt_to_bus users and instead fix the actual
> code to use the right functions?

Absolutely.  But I currently just want my trees to build (I am a bear of
little brain with simple needs :-))

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()

[Sean MacLennan]

On Mon, 28 Jul 2008 02:37:32 +1000
"Stephen Rothwell" <sfr@canb.auug.org.au> wrote:

> On powerpc (allyesconfig build) we get this error:
> 
> drivers/isdn/hardware/mISDN/hfcpci.c:1991: error: implicit
> declaration of function 'virt_to_bus'

When did mISDN make it into the kernel? And which kernel tree is it in?
I don't see it in the Linux next tree....

I am very interested since we are trying to get mISDN working on the
Warp. There was no notice that they got 2.6.26 compiling.

Cheers,
   Sean

Re: [PATCH] isdn: mISDN HFC PCI support depends on virt_to_bus()

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 894 bytes --]

Hi Sean,

On Sun, 27 Jul 2008 13:39:18 -0400 Sean MacLennan <smaclennan@pikatech.com> wrote:
>
> On Mon, 28 Jul 2008 02:37:32 +1000
> "Stephen Rothwell" <sfr@canb.auug.org.au> wrote:
> 
> > On powerpc (allyesconfig build) we get this error:
> > 
> > drivers/isdn/hardware/mISDN/hfcpci.c:1991: error: implicit
> > declaration of function 'virt_to_bus'
> 
> When did mISDN make it into the kernel? And which kernel tree is it in?
> I don't see it in the Linux next tree....

Its not in linux-next (will be today).  It went straight into Linus' tree
late last week.

> I am very interested since we are trying to get mISDN working on the
> Warp. There was no notice that they got 2.6.26 compiling.

It won't even build on powerpc64, powercp32 should at least build.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]