gigantci pages patches

gigantci pages patches

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 994 bytes --]

Hi all,

Could people take one last look at these patches and if there are no
issues, please send Ack-bys to Andrew who will push them to Linus for
2.6.27.

[PATCH 1/6 v2] allow arch specific function for allocating gigantic pages
http://patchwork.ozlabs.org/linuxppc/patch?&id=18437
Patch: [PATCH 2/6 v2] powerpc: function for allocating gigantic pages
http://patchwork.ozlabs.org/linuxppc/patch?&id=18438
Patch: [PATCH 3/6 v2] powerpc: scan device tree and save gigantic page locations
http://patchwork.ozlabs.org/linuxppc/patch?&id=18439
Patch: [PATCH 4/6 v2] powerpc: define page support for 16G pages
http://patchwork.ozlabs.org/linuxppc/patch?&id=18440
Patch: [PATCH 5/6 v2] check for overflow
http://patchwork.ozlabs.org/linuxppc/patch?&id=18441
Patch: [PATCH 6/6] powerpc: support multiple huge page sizes
http://patchwork.ozlabs.org/linuxppc/patch?&id=18442

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: gigantci pages patches

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1665 bytes --]

On Fri, Jul 11, 2008 at 05:45:15PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> Could people take one last look at these patches and if there are no
> issues, please send Ack-bys to Andrew who will push them to Linus for
> 2.6.27.
> 
> [PATCH 1/6 v2] allow arch specific function for allocating gigantic pages
> http://patchwork.ozlabs.org/linuxppc/patch?&id=18437
> Patch: [PATCH 2/6 v2] powerpc: function for allocating gigantic pages
> http://patchwork.ozlabs.org/linuxppc/patch?&id=18438
> Patch: [PATCH 3/6 v2] powerpc: scan device tree and save gigantic page locations
> http://patchwork.ozlabs.org/linuxppc/patch?&id=18439
> Patch: [PATCH 4/6 v2] powerpc: define page support for 16G pages
> http://patchwork.ozlabs.org/linuxppc/patch?&id=18440
> Patch: [PATCH 5/6 v2] check for overflow
> http://patchwork.ozlabs.org/linuxppc/patch?&id=18441
> Patch: [PATCH 6/6] powerpc: support multiple huge page sizes
> http://patchwork.ozlabs.org/linuxppc/patch?&id=18442

Sorry, I should have looked at these properly when they went past in
May, but obviously I missed them.

They mostly look ok.  I'm a bit confused on 2/6 though - it seems the
new powerpc alloc_bootmem_huge_page() function is specific to the 16G
gigantic pages.  But can't that function also get called for the
normal 16M hugepages depending on how the hugepage pool is
initialized.

Or am I missing something (wouldn't surprise me given my brain's
sluggishness today)?

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: gigantci pages patches

[Jon Tollefson]

David Gibson wrote:
> On Fri, Jul 11, 2008 at 05:45:15PM +1000, Stephen Rothwell wrote:
>   
>> Hi all,
>>
>> Could people take one last look at these patches and if there are no
>> issues, please send Ack-bys to Andrew who will push them to Linus for
>> 2.6.27.
>>
>> [PATCH 1/6 v2] allow arch specific function for allocating gigantic pages
>> http://patchwork.ozlabs.org/linuxppc/patch?&id=18437
>> Patch: [PATCH 2/6 v2] powerpc: function for allocating gigantic pages
>> http://patchwork.ozlabs.org/linuxppc/patch?&id=18438
>> Patch: [PATCH 3/6 v2] powerpc: scan device tree and save gigantic page locations
>> http://patchwork.ozlabs.org/linuxppc/patch?&id=18439
>> Patch: [PATCH 4/6 v2] powerpc: define page support for 16G pages
>> http://patchwork.ozlabs.org/linuxppc/patch?&id=18440
>> Patch: [PATCH 5/6 v2] check for overflow
>> http://patchwork.ozlabs.org/linuxppc/patch?&id=18441
>> Patch: [PATCH 6/6] powerpc: support multiple huge page sizes
>> http://patchwork.ozlabs.org/linuxppc/patch?&id=18442
>>     
>
> Sorry, I should have looked at these properly when they went past in
> May, but obviously I missed them.
>
> They mostly look ok.  I'm a bit confused on 2/6 though - it seems the
> new powerpc alloc_bootmem_huge_page() function is specific to the 16G
> gigantic pages.  But can't that function also get called for the
> normal 16M hugepages depending on how the hugepage pool is
> initialized.
>
> Or am I missing something (wouldn't surprise me given my brain's
> sluggishness today)?
>   
The alloc_bootmem_huge_page() function is only called for pages >=
MAX_ORDER.  The 16M pages are always allocated within the generic
hugetlbfs code with alloc_pages_node().

Jon

Re: gigantci pages patches

[David Gibson]

On Tue, Jul 22, 2008 at 03:22:36PM -0500, Jon Tollefson wrote:
> David Gibson wrote:
> > On Fri, Jul 11, 2008 at 05:45:15PM +1000, Stephen Rothwell wrote:
> >   
> >> Hi all,
> >>
> >> Could people take one last look at these patches and if there are no
> >> issues, please send Ack-bys to Andrew who will push them to Linus for
> >> 2.6.27.
> >>
> >> [PATCH 1/6 v2] allow arch specific function for allocating gigantic pages
> >> http://patchwork.ozlabs.org/linuxppc/patch?&id=18437
> >> Patch: [PATCH 2/6 v2] powerpc: function for allocating gigantic pages
> >> http://patchwork.ozlabs.org/linuxppc/patch?&id=18438
> >> Patch: [PATCH 3/6 v2] powerpc: scan device tree and save gigantic page locations
> >> http://patchwork.ozlabs.org/linuxppc/patch?&id=18439
> >> Patch: [PATCH 4/6 v2] powerpc: define page support for 16G pages
> >> http://patchwork.ozlabs.org/linuxppc/patch?&id=18440
> >> Patch: [PATCH 5/6 v2] check for overflow
> >> http://patchwork.ozlabs.org/linuxppc/patch?&id=18441
> >> Patch: [PATCH 6/6] powerpc: support multiple huge page sizes
> >> http://patchwork.ozlabs.org/linuxppc/patch?&id=18442
> >>     
> >
> > Sorry, I should have looked at these properly when they went past in
> > May, but obviously I missed them.
> >
> > They mostly look ok.  I'm a bit confused on 2/6 though - it seems the
> > new powerpc alloc_bootmem_huge_page() function is specific to the 16G
> > gigantic pages.  But can't that function also get called for the
> > normal 16M hugepages depending on how the hugepage pool is
> > initialized.
> >
> > Or am I missing something (wouldn't surprise me given my brain's
> > sluggishness today)?
> >   
> The alloc_bootmem_huge_page() function is only called for pages >=
> MAX_ORDER.  The 16M pages are always allocated within the generic
> hugetlbfs code with alloc_pages_node().

Ah, ok.  Well, in that case:

Acked-by: David Gibson <dwg@au1.ibm.com>

for the series.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Re: gigantci pages patches

[Andrew Morton]

On Mon, 28 Jul 2008 11:07:57 +1000 David Gibson <dwg@au1.ibm.com> wrote:

> On Tue, Jul 22, 2008 at 03:22:36PM -0500, Jon Tollefson wrote:
> > David Gibson wrote:
> > > On Fri, Jul 11, 2008 at 05:45:15PM +1000, Stephen Rothwell wrote:
> > >   
> > >> Hi all,
> > >>
> > >> Could people take one last look at these patches and if there are no
> > >> issues, please send Ack-bys to Andrew who will push them to Linus for
> > >> 2.6.27.
> > >>
> > >> [PATCH 1/6 v2] allow arch specific function for allocating gigantic pages
> > >> http://patchwork.ozlabs.org/linuxppc/patch?&id=18437
> > >> Patch: [PATCH 2/6 v2] powerpc: function for allocating gigantic pages
> > >> http://patchwork.ozlabs.org/linuxppc/patch?&id=18438
> > >> Patch: [PATCH 3/6 v2] powerpc: scan device tree and save gigantic page locations
> > >> http://patchwork.ozlabs.org/linuxppc/patch?&id=18439
> > >> Patch: [PATCH 4/6 v2] powerpc: define page support for 16G pages
> > >> http://patchwork.ozlabs.org/linuxppc/patch?&id=18440
> > >> Patch: [PATCH 5/6 v2] check for overflow
> > >> http://patchwork.ozlabs.org/linuxppc/patch?&id=18441
> > >> Patch: [PATCH 6/6] powerpc: support multiple huge page sizes
> > >> http://patchwork.ozlabs.org/linuxppc/patch?&id=18442
> > >>     
> > >
> > > Sorry, I should have looked at these properly when they went past in
> > > May, but obviously I missed them.
> > >
> > > They mostly look ok.  I'm a bit confused on 2/6 though - it seems the
> > > new powerpc alloc_bootmem_huge_page() function is specific to the 16G
> > > gigantic pages.  But can't that function also get called for the
> > > normal 16M hugepages depending on how the hugepage pool is
> > > initialized.
> > >
> > > Or am I missing something (wouldn't surprise me given my brain's
> > > sluggishness today)?
> > >   
> > The alloc_bootmem_huge_page() function is only called for pages >=
> > MAX_ORDER.  The 16M pages are always allocated within the generic
> > hugetlbfs code with alloc_pages_node().
> 
> Ah, ok.  Well, in that case:
> 
> Acked-by: David Gibson <dwg@au1.ibm.com>
> 
> for the series

OK.  Although I'm no longer sure what patches "for the series" refers to.

I am currently retaining

powerpc-implement-pte_special.patch
powerpc-implement-pte_special-update.patch
powerpc-lockless-get_user_pages.patch

and frankly I'm unsure what the status is.  I have a note that benh had
concerns about powerpc-lockless-get_user_pages.patch, but iirc they
were waffly and vague ;)

So I'm thinking I'll stick these patches onto my send-to-ben list.

Re: gigantci pages patches

[Benjamin Herrenschmidt]

On Sun, 2008-07-27 at 20:17 -0700, Andrew Morton wrote:
> s
> 
> OK.  Although I'm no longer sure what patches "for the series" refers to.
> 
> I am currently retaining
> 
> powerpc-implement-pte_special.patch
> powerpc-implement-pte_special-update.patch
> powerpc-lockless-get_user_pages.patch
> 
> and frankly I'm unsure what the status is.  I have a note that benh had
> concerns about powerpc-lockless-get_user_pages.patch, but iirc they
> were waffly and vague ;)
> 
> So I'm thinking I'll stick these patches onto my send-to-ben list.

Ok, send the latest ones you have to me, and I'll sort things you.

Cheers,
Ben.