From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e23smtp05.au.ibm.com (E23SMTP05.au.ibm.com [202.81.18.174]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "e23smtp05.au.ibm.com", Issuer "Equifax" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 02479DE13A for ; Mon, 28 Jul 2008 11:08:02 +1000 (EST) Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [202.81.18.234]) by e23smtp05.au.ibm.com (8.13.1/8.13.1) with ESMTP id m6S17Gmt032043 for ; Mon, 28 Jul 2008 11:07:16 +1000 Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m6S182594407496 for ; Mon, 28 Jul 2008 11:08:02 +1000 Received: from d23av01.au.ibm.com (loopback [127.0.0.1]) by d23av01.au.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m6S181Gq006484 for ; Mon, 28 Jul 2008 11:08:02 +1000 Date: Mon, 28 Jul 2008 11:07:57 +1000 From: David Gibson To: Jon Tollefson Subject: Re: gigantci pages patches Message-ID: <20080728010757.GF11318@yookeroo.seuss> References: <20080711174515.1aacf83b.sfr@canb.auug.org.au> <20080722033417.GD14888@yookeroo.seuss> <4886418C.9050704@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <4886418C.9050704@linux.vnet.ibm.com> Cc: npiggin@suse.de, Stephen Rothwell , ppc-dev , paulus@samba.org, Andrew Morton List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Jul 22, 2008 at 03:22:36PM -0500, Jon Tollefson wrote: > David Gibson wrote: > > On Fri, Jul 11, 2008 at 05:45:15PM +1000, Stephen Rothwell wrote: > > > >> Hi all, > >> > >> Could people take one last look at these patches and if there are no > >> issues, please send Ack-bys to Andrew who will push them to Linus for > >> 2.6.27. > >> > >> [PATCH 1/6 v2] allow arch specific function for allocating gigantic pages > >> http://patchwork.ozlabs.org/linuxppc/patch?&id=18437 > >> Patch: [PATCH 2/6 v2] powerpc: function for allocating gigantic pages > >> http://patchwork.ozlabs.org/linuxppc/patch?&id=18438 > >> Patch: [PATCH 3/6 v2] powerpc: scan device tree and save gigantic page locations > >> http://patchwork.ozlabs.org/linuxppc/patch?&id=18439 > >> Patch: [PATCH 4/6 v2] powerpc: define page support for 16G pages > >> http://patchwork.ozlabs.org/linuxppc/patch?&id=18440 > >> Patch: [PATCH 5/6 v2] check for overflow > >> http://patchwork.ozlabs.org/linuxppc/patch?&id=18441 > >> Patch: [PATCH 6/6] powerpc: support multiple huge page sizes > >> http://patchwork.ozlabs.org/linuxppc/patch?&id=18442 > >> > > > > Sorry, I should have looked at these properly when they went past in > > May, but obviously I missed them. > > > > They mostly look ok. I'm a bit confused on 2/6 though - it seems the > > new powerpc alloc_bootmem_huge_page() function is specific to the 16G > > gigantic pages. But can't that function also get called for the > > normal 16M hugepages depending on how the hugepage pool is > > initialized. > > > > Or am I missing something (wouldn't surprise me given my brain's > > sluggishness today)? > > > The alloc_bootmem_huge_page() function is only called for pages >= > MAX_ORDER. The 16M pages are always allocated within the generic > hugetlbfs code with alloc_pages_node(). Ah, ok. Well, in that case: Acked-by: David Gibson for the series. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson