* libfdt: Forgot one function when cleaning the namespace
@ 2008-07-29 4:51 David Gibson
2008-07-31 15:38 ` Jon Loeliger
0 siblings, 1 reply; 2+ messages in thread
From: David Gibson @ 2008-07-29 4:51 UTC (permalink / raw)
To: Jon Loeliger; +Cc: linuxppc-dev
In commit b6d80a20fc293f3b995c3ce1a6744a5574192125, we renamed all
libfdt functions to be prefixed with fdt_ or _fdt_ to minimise the
chance of collisions with things from whatever package libfdt is
embedded in, pulled into the libfdt build via that environment's
libfdt_env.h.
Except... I missed one. This patch applies the same treatment to
_stringlist_contains(). While we're at it, also make it static since
it's only used in the same file.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Index: dtc/libfdt/fdt_ro.c
===================================================================
--- dtc.orig/libfdt/fdt_ro.c 2008-07-29 13:43:23.000000000 +1000
+++ dtc/libfdt/fdt_ro.c 2008-07-29 13:43:33.000000000 +1000
@@ -408,7 +408,8 @@ int fdt_node_offset_by_phandle(const voi
&phandle, sizeof(phandle));
}
-int _stringlist_contains(const char *strlist, int listlen, const char *str)
+static int _fdt_stringlist_contains(const char *strlist, int listlen,
+ const char *str)
{
int len = strlen(str);
const char *p;
@@ -434,7 +435,7 @@ int fdt_node_check_compatible(const void
prop = fdt_getprop(fdt, nodeoffset, "compatible", &len);
if (!prop)
return len;
- if (_stringlist_contains(prop, len, compatible))
+ if (_fdt_stringlist_contains(prop, len, compatible))
return 0;
else
return 1;
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: libfdt: Forgot one function when cleaning the namespace
2008-07-29 4:51 libfdt: Forgot one function when cleaning the namespace David Gibson
@ 2008-07-31 15:38 ` Jon Loeliger
0 siblings, 0 replies; 2+ messages in thread
From: Jon Loeliger @ 2008-07-31 15:38 UTC (permalink / raw)
To: David Gibson; +Cc: linuxppc-dev
> In commit b6d80a20fc293f3b995c3ce1a6744a5574192125, we renamed all
> libfdt functions to be prefixed with fdt_ or _fdt_ to minimise the
> chance of collisions with things from whatever package libfdt is
> embedded in, pulled into the libfdt build via that environment's
> libfdt_env.h.
>
> Except... I missed one. This patch applies the same treatment to
> _stringlist_contains(). While we're at it, also make it static since
> it's only used in the same file.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Applied.
jdl
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-31 15:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-29 4:51 libfdt: Forgot one function when cleaning the namespace David Gibson
2008-07-31 15:38 ` Jon Loeliger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).