From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 1 Aug 2008 13:20:27 +1000 From: David Gibson To: Kumar Gala Subject: Re: [PATCH] powerpc: Fix whitespace merge in mpc8641 hpcn device tree Message-ID: <20080801032027.GE5008@yookeroo.seuss> References: <48923A43.9040901@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Jul 31, 2008 at 05:28:09PM -0500, Kumar Gala wrote: > > On Jul 31, 2008, at 5:18 PM, Jon Loeliger wrote: > >> Kumar Gala wrote: >>> When we coverted the .dts to v1 we lost a space between the irq >>> and its polarity/sense information. This causes a bit of chaos >>> as the reset of the blob is off by one cell. >>> >>> diff --git a/arch/powerpc/boot/dts/mpc8641_hpcn.dts b/arch/powerpc/ >>> boot/dts/mpc8641_hpcn.dts >>> index ae08761..d665e76 100644 >>> --- a/arch/powerpc/boot/dts/mpc8641_hpcn.dts >>> +++ b/arch/powerpc/boot/dts/mpc8641_hpcn.dts >>> @@ -411,7 +411,7 @@ >>> 0xe000 0 0 1 &i8259 12 2 >>> 0xe100 0 0 2 &i8259 9 2 >>> 0xe200 0 0 3 &i8259 10 2 >>> - 0xe300 0 0 4 &i8259 112 >>> + 0xe300 0 0 4 &i8259 11 2 >> >> Ouch. That was probably my typo and fault. >> >> Apologies. > > np. It would be nice to see dtc warn about it, but that would probably > be a bit difficult. It shouldn't be that hard to make a rudimentary interrupt-map checker that would catch at least an error as basic as this. Just no-one's implemented it yet. Patches welcome ;-) -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson