linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Sean MacLennan <smaclennan@pikatech.com>
To: "Adrian Bunk" <bunk@kernel.org>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org, Stefan Roese <sr@denx.de>
Subject: Re: platforms/44x/warp-nand.c bogosity
Date: Fri, 1 Aug 2008 11:41:07 -0400	[thread overview]
Message-ID: <20080801114107.067904f8@lappy.seanm.ca> (raw)
In-Reply-To: <20080801151401.GC24735@cs181140183.pp.htv.fi>

On Fri, 1 Aug 2008 18:14:01 +0300
"Adrian Bunk" <bunk@kernel.org> wrote:

> arch/powerpc/platforms/44x/warp-nand.c was added this year and
> updated quite recently.
> 
> warp-nand.c is empty unless CONFIG_MTD_NAND_NDFC=y.
> 
> MTD_NAND_NDFC depends on !PPC_MERGE.
> 
> !PPC_MERGE can never be true on PPC now that arch/ppc/ got removed.
> 
> So warp-nand.c is dead code, but that does not seem to be
> intentionally?

I use a local copy of ndfc.c that was modified to work with
arch/powerpc. I submitted the patch, but it was never accepted into the
kernel, and to be honest I don't remember why. I will look into this.

So the code is definitely not dead. You can't realistically run a warp
without the NAND.

Cheers,
   Sean

      parent reply	other threads:[~2008-08-01 15:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-01 15:14 platforms/44x/warp-nand.c bogosity Adrian Bunk
2008-08-01 15:26 ` Josh Boyer
2008-08-01 15:32   ` Valentine Barshak
2008-08-02  3:42     ` Sean MacLennan
2008-08-01 15:59   ` Sean MacLennan
2008-08-01 15:41 ` Sean MacLennan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080801114107.067904f8@lappy.seanm.ca \
    --to=smaclennan@pikatech.com \
    --cc=bunk@kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=sr@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).