From: Adrian Bunk <bunk@kernel.org>
To: ashish kalra <ashish.kalra@freescale.com>,
Li Yang <leoli@freescale.com>, Jeff Garzik <jeff@garzik.org>,
galak@kernel.crashing.org
Cc: linuxppc-dev@ozlabs.org,
"Robert P. J. Day" <rpjday@crashcourse.ca>,
linux-ide@vger.kernel.org
Subject: [2.6 patch] sata_fsl.c: fix 8315DS workaround
Date: Mon, 4 Aug 2008 11:46:11 +0300 [thread overview]
Message-ID: <20080804084611.GA6088@cs181140183.pp.htv.fi> (raw)
Commit e7eac96e8f0e57a6e9f94943557bc2b23be31471 (ata/sata_fsl: Move
MPC8315DS link speed limit workaround to specific ifdef) aimed at
limiting the workaround only to the affected hardware, but since the
#ifdef used a nonexisting kconfig variable it actually killed
the workaround.
Reported-by: Robert P. J. Day <rpjday@crashcourse.ca>
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
cd54dd8b6a8bca44ead212d12fe116702cc31ed7
diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
index 3924e72..45878ef 100644
--- a/drivers/ata/sata_fsl.c
+++ b/drivers/ata/sata_fsl.c
@@ -640,7 +640,7 @@ static int sata_fsl_port_start(struct ata_port *ap)
VPRINTK("HControl = 0x%x\n", ioread32(hcr_base + HCONTROL));
VPRINTK("CHBA = 0x%x\n", ioread32(hcr_base + CHBA));
-#ifdef CONFIG_MPC8315_DS
+#ifdef CONFIG_MPC831x_RDB
/*
* Workaround for 8315DS board 3gbps link-up issue,
* currently limit SATA port to GEN1 speed
next reply other threads:[~2008-08-04 8:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-04 8:46 Adrian Bunk [this message]
2008-08-04 8:55 ` [2.6 patch] sata_fsl.c: fix 8315DS workaround Li Yang
2008-08-04 9:22 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080804084611.GA6088@cs181140183.pp.htv.fi \
--to=bunk@kernel.org \
--cc=ashish.kalra@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=jeff@garzik.org \
--cc=leoli@freescale.com \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox