From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 7 Aug 2008 10:40:22 +1000 From: David Gibson To: Segher Boessenkool Subject: Re: [RFC/PATCH 2/3] of: add of_lookup_stdout() utility function Message-ID: <20080807004022.GA24443@yookeroo.seuss> References: <20080806055214.30717.86092.stgit@trillian.secretlab.ca> <20080806060239.30717.79273.stgit@trillian.secretlab.ca> <20080805.233205.201125898.davem@davemloft.net> <18585.31504.836857.829592@cargo.ozlabs.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Cc: linuxppc-dev@ozlabs.org, devicetree-discuss@ozlabs.org, David Miller , miltonm@bga.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Aug 06, 2008 at 06:25:48PM +0200, Segher Boessenkool wrote: >> It's not what we do with flattened device trees blobs though. In the >> flattened tree we're not using a /chosen/stdout property, just the >> linux,stdout-path one. >> >> The question that remains is; should there be? Should the dt blobs >> use /chosen/stdout also? (I'm not familiar enough with real OF to >> know the answer. I'm assuming that an instance value is not the same >> as a phandle). > > ihandles and phandles are not the same thing in OF. Since in the > "flat world" we cannot have instances, we should use phandles instead > of ihandles for the things in /chosen. I thought we agreed on that > already, perhaps I am wrong? Not that I recall. In general we've been avoiding using anything that traditionally contains an ihandle; hence the direct use of linux,stdout-path when using a flat tree. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson