From: Jean Delvare <khali@linux-fr.org>
To: Jochen Friedrich <jochen@scram.de>
Cc: Linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] i2c-mpc: suppress I2C device probing
Date: Thu, 7 Aug 2008 13:07:17 +0200 [thread overview]
Message-ID: <20080807130717.56694249@hyperion.delvare> (raw)
In-Reply-To: <489AD363.6070608@scram.de>
On Thu, 07 Aug 2008 12:50:11 +0200, Jochen Friedrich wrote:
> Hi Wolfgang,
>
> > $ grep I2C_CLASS_HWMON *
> > i2c-cpm.c: .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
> > i2c-mpc.c: .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
> > i2c-ibm_iic.c: adap->class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
> > i2c-pasemi.c: smbus->adapter.class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
> > i2c-mv64xxx.c: drv_data->adapter.class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
> >
> > It would be consequent to remove them as well.
>
> ACK for the i2c-cpm part.
No objection on my side. It's really up to each platform to choose the
way they want to handle i2c device creation, and stick to it.
As I understand it, the removal of the adapter class needs to be
synchronized with platform code changes. Thus it might make sense to
push these through their respective arch trees, rather than the i2c
tree.
--
Jean Delvare
next prev parent reply other threads:[~2008-08-07 11:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-17 10:37 [PATCH] i2c-mpc: suppress I2C device probing Wolfgang Grandegger
2008-07-17 18:02 ` Grant Likely
2008-08-07 8:21 ` Jean Delvare
2008-08-07 10:20 ` Wolfgang Grandegger
2008-08-07 10:50 ` Jochen Friedrich
2008-08-07 11:07 ` Jean Delvare [this message]
2008-08-07 14:33 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080807130717.56694249@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=Linuxppc-dev@ozlabs.org \
--cc=jochen@scram.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox