From: Sebastian Siewior <sebastian@breakpoint.cc>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: netdev@vger.kernel.org, Sebastian Siewior <bigeasy@linutronix.de>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH / RFC] net: fix locking in ibm_newemac
Date: Thu, 14 Aug 2008 09:33:19 +0200 [thread overview]
Message-ID: <20080814073319.GA8716@Chamillionaire.breakpoint.cc> (raw)
In-Reply-To: <1218685554.8041.172.camel@pasglop>
* Benjamin Herrenschmidt | 2008-08-14 13:45:54 [+1000]:
>> The fix is to defer phy init until netdevice is registered / initialized.
>
>I think it's better instead to take the dev_mc_add() statement
>out of emac_configure().
I looked yesterday into that code and I saw that dev_mc_add() was called
by the network core itself. Now I'm sure it was definitly too late for
writing patches :)
>What about this patch instead, does it fix it for you ?
yep it does.
Sebastian
prev parent reply other threads:[~2008-08-14 7:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-13 18:29 [PATCH / RFC] net: fix locking in ibm_newemac Sebastian Siewior
2008-08-14 3:45 ` Benjamin Herrenschmidt
2008-08-14 7:33 ` Sebastian Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080814073319.GA8716@Chamillionaire.breakpoint.cc \
--to=sebastian@breakpoint.cc \
--cc=benh@kernel.crashing.org \
--cc=bigeasy@linutronix.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).