From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 20 Aug 2008 14:39:08 +0200 From: Robert Richter To: Arnd Bergmann Subject: Re: powerpc/cell/oprofile: fix mutex locking for spu-oprofile Message-ID: <20080820123907.GP13011@erda.amd.com> References: <1217620879.15667.145.camel@carll-linux-desktop> <200808110925.08485.arnd@arndb.de> <20080820115750.GO13011@erda.amd.com> <200808201405.32101.arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <200808201405.32101.arnd@arndb.de> Cc: linux-kernel , linuxppc-dev@ozlabs.org, Paul Mackerras , oprofile-list@lists.sourceforge.net, cel , cbe-oss-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 20.08.08 14:05:31, Arnd Bergmann wrote: > On Wednesday 20 August 2008, Robert Richter wrote: > > I am fine with the changes with the exception of removing > > add_event_entry() from include/linux/oprofile.h. Though there is no > > usage of the function also in other architectures anymore, this change > > in the API should be discussed on the oprofile mailing list. Please > > separate the change in a different patch and submit it to the mailing > > list. If there are no objections then, this change can go upstream as > > well. > > As an explanation, the removal of add_event_entry is the whole point > of this patch. add_event_entry must only be called with buffer_mutex > held, but buffer_mutex itself is not exported. Thanks for pointing this out. > I'm pretty sure that no other user of add_event_entry exists, as it > was exported specifically for the SPU support and that never worked. > Any other (theoretical) code using it would be broken in the same way > and need a corresponding fix. > > We can easily leave the declaration in place, but I'd recommend removing > it eventually. If you prefer to keep it, how about marking it as > __deprecated? No, since this is broken by design we remove it. The patch can go upstream as it is. Thanks, -Robert -- Advanced Micro Devices, Inc. Operating System Research Center email: robert.richter@amd.com