From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: "Steven A. Falco" <sfalco@harris.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [RFC][PATCH] I2C driver
Date: Thu, 21 Aug 2008 13:17:12 -0400 [thread overview]
Message-ID: <20080821131712.5254a13e@zod.rchland.ibm.com> (raw)
In-Reply-To: <48ADA090.8020100@harris.com>
On Thu, 21 Aug 2008 13:06:24 -0400
"Steven A. Falco" <sfalco@harris.com> wrote:
> Josh Boyer wrote:
> > On Thu, 2008-08-21 at 12:21 -0400, Steven A. Falco wrote:
> >> The following patch enables building the I2C driver for 4xx chips.
> >> Tested on a Sequoia board. Comments invited.
> >>
> >> Signed-off-by: Steven A. Falco <sfalco@harris.com>
> >> ---
> >> drivers/i2c/busses/Kconfig | 7 +++++++
> >> drivers/i2c/busses/i2c-ibm_of.c | 5 ++---
> >> 2 files changed, 9 insertions(+), 3 deletions(-)
> >
> > That file doesn't even exist in the mainline kernel:
> >
> > [jwboyer@yoda linux-2.6]$ find drivers/i2c/ -name *ibm*
> > drivers/i2c/busses/i2c-ibm_iic.c
> > drivers/i2c/busses/i2c-ibm_iic.h
> > [jwboyer@yoda linux-2.6]$
> >
> > josh
> >
> >
>
> Interesting. Ok - I found the problem with the driver you *did* find:
.26 doesn't have what can be considered awesome i2c support. But the
latest git trees are much better. See git commits:
d3dc685eb5ef64aa695dabb74f00440ec3ab6796
and
b1204e6ec16468ebf89d9d818bfe425ca7adcdf3
They deal with the problems you highlighted with the listing and index
stuff. There might be more issues outstanding, but using the latest
kernel is going to get you better support and prevent you from finding
problems that are already fixed :)
josh
next prev parent reply other threads:[~2008-08-21 17:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 16:21 [RFC][PATCH] I2C driver Steven A. Falco
2008-08-21 16:30 ` Josh Boyer
2008-08-21 17:06 ` Steven A. Falco
2008-08-21 17:17 ` Josh Boyer [this message]
2008-08-21 17:27 ` Sean MacLennan
2008-08-21 19:05 ` Stefan Roese
2008-08-21 20:37 ` Steven A. Falco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080821131712.5254a13e@zod.rchland.ibm.com \
--to=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfalco@harris.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).