From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Markus Brunner <super.firetwister@googlemail.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] add a simple 405EP based board
Date: Thu, 21 Aug 2008 18:52:02 +1000 [thread overview]
Message-ID: <20080821185202.24cb6810.sfr@canb.auug.org.au> (raw)
In-Reply-To: <200808211007.59965.super.firetwister@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 673 bytes --]
Hi Markus,
One small nit:
On Thu, 21 Aug 2008 10:07:58 +0200 Markus Brunner <super.firetwister@googlemail.com> wrote:
>
> +#include <linux/init.h>
> +#include <linux/of_platform.h>
> +
> +#include <asm/machdep.h>
> +#include <asm/ppc4xx.h>
> +#include <asm/time.h>
> +#include <asm/udbg.h>
> +#include <asm/uic.h>
> +
> +static int __init ppc405ep_probe(void)
> +{
> + unsigned long root = of_get_flat_dt_root();
> + if (!of_flat_dt_is_compatible(root, "company,ppc405ep"))
You need to include <asm/prom.h> to use the of_flat ... routines.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-08-21 8:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 8:07 [PATCH] add a simple 405EP based board Markus Brunner
2008-08-21 8:52 ` Stephen Rothwell [this message]
2008-08-21 11:55 ` Josh Boyer
2008-08-21 12:46 ` M B
2008-08-21 13:42 ` Arnd Bergmann
2008-08-21 16:10 ` Josh Boyer
2008-08-22 12:39 ` Arnd Bergmann
2008-08-26 0:41 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080821185202.24cb6810.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=super.firetwister@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).