Re: [PATCH v2 1/2] powerpc: Board support for GE Fanuc SBC610

[Martyn Welch <martyn.welch@gefanuc.com>]

On Fri, 22 Aug 2008 12:11:52 +0100
Martyn Welch <martyn.welch@gefanuc.com> wrote:

> On Fri, 22 Aug 2008 05:56:53 -0500
> Kumar Gala <galak@kernel.crashing.org> wrote:
> 
> > >
> > > +		PowerPC,8641@0 {
> > > +			device_type = "cpu";
> > > +			reg = <0x00000000>;
> > > +			d-cache-line-size = <32>;	// 32 bytes
> > > +			i-cache-line-size = <32>;	// 32 bytes
> > > +			d-cache-size = <32768>;		// L1, 32K
> > > +			i-cache-size = <32768>;		// L1, 32K
> > > +			timebase-frequency = <0>;	// From uboot
> > > +			bus-frequency = <0>;		// From uboot
> > > +			clock-frequency = <0>;		// From uboot
> > > +			l2cr = <0x80000000>;		// Enable L2
> > 
> > do you expect the 'l2cr' prop to do anything?  Not sure if this is  
> > something apple invented or you did?
> > 
> 
> TBH, it was in the dts file that I based this on - I thought it was in the others as well - my mistake, I shall remove it.
> 
> > 
> > >
> > > +		i2c1: i2c@3000 {
> > > +			#address-cells = <1>;
> > > +			#size-cells = <0>;
> > > +			device_type = "i2c";
> > 
> > drop device_type.
> > 
> 
> Ah - _all_ device_type!
> 

Um, not all - just the ones where the name of the block matches the device type(?)

Martyn

-- 
Martyn Welch MEng MPhil MIET (Principal Software Engineer)   T:+44(0)1327322748
GE Fanuc Intelligent Platforms Ltd,        |Registered in England and Wales
Tove Valley Business Park, Towcester,      |(3828642) at 100 Barbirolli Square,
Northants, NN12 6PF, UK T:+44(0)1327359444 |Manchester,M2 3AB  VAT:GB 729849476