From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp3.yandex.ru (smtp3.yandex.ru [213.180.223.87]) by ozlabs.org (Postfix) with ESMTP id 49EE8DE771 for ; Tue, 26 Aug 2008 01:02:30 +1000 (EST) Received: from cifronik.21th.com ([62.16.86.116]:31966 "EHLO satanklaus.cifronic.local" smtp-auth: "temerkhanov" TLS-CIPHER: TLS-PEER-CN1: ) by mail.yandex.ru with ESMTP id S4747707AbYHYPCV (ORCPT ); Mon, 25 Aug 2008 19:02:21 +0400 From: Sergey Temerkhanov To: linuxppc-dev@ozlabs.org Subject: Re: [PATCH] [RFC] Fix level IRQ handling on Xilinx INTC with ARCH=powerpc Date: Mon, 25 Aug 2008 19:02:58 +0400 References: <200808251656.00247.temerkhanov@yandex.ru> In-Reply-To: MIME-Version: 1.0 Message-Id: <200808251902.58916.temerkhanov@yandex.ru> Content-Type: text/plain; charset="iso-8859-1" Reply-To: temerkhanov@cifronik.ru List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Monday 25 August 2008 18:26:54 Grant Likely wrote: >This > patch unconditionally adds what is essentially a device specific fixup > to *every* Linux platform. I cannot see that flying very far. > I know that. But without IRQ_CHIP_UNMASK_ACK set this fixup won'be applied so setups that are not affected should work as before. This problem was already discussed before: http://www.nabble.com/Level-IRQ-handling-on-Xilinx-INTC-with-ARCH%3Dpowerpc-td18711173.html Of course, I can just modify xilinx_intc_unmask() routine to perform acknowledge as I did before, but it seems a hack to me.