From: Stefan Roese <sr@denx.de>
To: linuxppc-dev@ozlabs.org
Cc: wd@denx.de, Ilya Yanok <yanok@emcraft.com>
Subject: Re: [PATCH] ppc4xx_pci: necessary fixes for 4GB RAM size
Date: Thu, 28 Aug 2008 16:18:31 +0200 [thread overview]
Message-ID: <200808281618.31652.sr@denx.de> (raw)
In-Reply-To: <20080828092820.2cacaba7@zod.rchland.ibm.com>
On Thursday 28 August 2008, Josh Boyer wrote:
> > 1. total_memory should be phys_addr_t not unsigned long
> > 2. is_power_of_2() works with u32 so I just inlined (size & (size-1)) !=
> > 0 instead.
> > Also this patch fixes default initialization: res->end should be
> > 0x7fffffff not 0x80000000.
> >
> > Signed-off-by: Ilya Yanok <yanok@emcraft.com>
>
> Ben, any comments here? Looks right to me.
Looks good to me too. So:
Acked-by: Stefan Roese <sr@denx.de>
Best regards,
Stefan
next prev parent reply other threads:[~2008-08-28 14:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-22 7:43 [PATCH] ppc4xx_pci: necessary fixes for 4GB RAM size Ilya Yanok
2008-08-28 13:28 ` Josh Boyer
2008-08-28 14:18 ` Stefan Roese [this message]
2008-09-01 0:19 ` Benjamin Herrenschmidt
2008-09-01 7:31 ` Ilya Yanok
2008-09-01 7:53 ` [PATCH] ppc4xx_pci: necessary fixes for 4GB RAM size (updated) Ilya Yanok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808281618.31652.sr@denx.de \
--to=sr@denx.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=wd@denx.de \
--cc=yanok@emcraft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).