linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [RFC PATCH 2/2] powerpc/83xx: mpc836x_mds: add support for USB Host
@ 2008-08-25 15:27 Anton Vorontsov
  2008-08-26  5:24 ` David Gibson
  2008-09-01 13:34 ` [RFC PATCH 2/2 v2] " Anton Vorontsov
  0 siblings, 2 replies; 5+ messages in thread
From: Anton Vorontsov @ 2008-08-25 15:27 UTC (permalink / raw)
  To: Kumar Gala; +Cc: linuxppc-dev, Li Yang

Various changes to support QE USB Host on a MPC8360E-MDS board:

- Update the device tree per QE USB bindings;
- Configure QE Par IO;
- Set up BCSR for both USB Host and Peripheral modes;
- Add timer (GTM) node;
- Add gpio-controller node for BCSR13 bank;
- Select FSL_GTM, QE_GPIO and OF_SIMPLE_GPIO.

The work is loosely based on Li Yang's patch[1], which is used
to support peripheral mode only.

[1] http://ozlabs.org/pipermail/linuxppc-dev/2008-August/061357.html

The s-o-b line of the original patch preserved here.

Signed-off-by: Li Yang <leoli@freescale.com>
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
 arch/powerpc/boot/dts/mpc836x_mds.dts     |   44 +++++++++++++++++++++++++++-
 arch/powerpc/platforms/83xx/Kconfig       |    3 ++
 arch/powerpc/platforms/83xx/mpc836x_mds.c |   31 +++++++++++++++++++-
 3 files changed, 75 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/boot/dts/mpc836x_mds.dts b/arch/powerpc/boot/dts/mpc836x_mds.dts
index ada8446..0be98f3 100644
--- a/arch/powerpc/boot/dts/mpc836x_mds.dts
+++ b/arch/powerpc/boot/dts/mpc836x_mds.dts
@@ -69,8 +69,19 @@
 		};
 
 		bcsr@1,0 {
+			#address-cells = <1>;
+			#size-cells = <1>;
 			device_type = "board-control";
 			reg = <1 0 0x8000>;
+			ranges = <0 1 0 0x8000>;
+
+			bcsr13: gpio-controller@d {
+				#gpio-cells = <2>;
+				compatible = "fsl,mpc8360mds-bcsr-gpio",
+					     "simple-gpio-bank";
+				reg = <0xd 1>;
+				gpio-controller;
+			};
 		};
 	};
 
@@ -191,10 +202,21 @@
 		};
 
 		par_io@1400 {
+			#address-cells = <1>;
+			#size-cells = <1>;
 			reg = <0x1400 0x100>;
+			ranges = <0 0x1400 0x100>;
 			device_type = "par_io";
 			num-ports = <7>;
 
+			qe_pio_b: gpio-controller@18 {
+				#gpio-cells = <2>;
+				compatible = "fsl,mpc8360-qe-pario-bank",
+					     "fsl,mpc8323-qe-pario-bank";
+				reg = <0x18 0x18>;
+				gpio-controller;
+			};
+
 			pio1: ucc_pin@01 {
 				pio-map = <
 			/* port  pin  dir  open_drain  assignment  has_irq */
@@ -278,6 +300,15 @@
 			};
 		};
 
+		timer@440 {
+			compatible = "fsl,mpc8360-qe-gtm",
+				     "fsl,qe-gtm", "fsl,gtm";
+			reg = <0x440 0x40>;
+			clock-frequency = <132000000>;
+			interrupts = <12 13 14 15>;
+			interrupt-parent = <&qeic>;
+		};
+
 		spi@4c0 {
 			cell-index = <0>;
 			compatible = "fsl,spi";
@@ -297,11 +328,20 @@
 		};
 
 		usb@6c0 {
-			compatible = "qe_udc";
+			compatible = "fsl,mpc8360-qe-usb",
+				     "fsl,mpc8323-qe-usb";
 			reg = <0x6c0 0x40 0x8b00 0x100>;
 			interrupts = <11>;
 			interrupt-parent = <&qeic>;
-			mode = "slave";
+			fsl,fullspeed-clock = "clk21";
+			fsl,lowspeed-clock = "brg9";
+			gpios = <&qe_pio_b  2 0   /* USBOE */
+				 &qe_pio_b  3 0   /* USBTP */
+				 &qe_pio_b  8 0   /* USBTN */
+				 &qe_pio_b  9 0   /* USBRP */
+				 &qe_pio_b 11 0   /* USBRN */
+				 &bcsr13    5 0   /* SPEED */
+				 &bcsr13    4 1>; /* POWER */
 		};
 
 		enet0: ucc@2000 {
diff --git a/arch/powerpc/platforms/83xx/Kconfig b/arch/powerpc/platforms/83xx/Kconfig
index 6159c5d..558458d 100644
--- a/arch/powerpc/platforms/83xx/Kconfig
+++ b/arch/powerpc/platforms/83xx/Kconfig
@@ -58,6 +58,9 @@ config MPC836x_MDS
 	bool "Freescale MPC836x MDS"
 	select DEFAULT_UIMAGE
 	select QUICC_ENGINE
+	select QE_GPIO
+	select OF_SIMPLE_GPIO
+	select FSL_GTM
 	help
 	  This option enables support for the MPC836x MDS Processor Board.
 
diff --git a/arch/powerpc/platforms/83xx/mpc836x_mds.c b/arch/powerpc/platforms/83xx/mpc836x_mds.c
index 9d46e5b..58aabfb 100644
--- a/arch/powerpc/platforms/83xx/mpc836x_mds.c
+++ b/arch/powerpc/platforms/83xx/mpc836x_mds.c
@@ -127,9 +127,38 @@ static void __init mpc836x_mds_setup_arch(void)
 			iounmap(immap);
 		}
 
-		iounmap(bcsr_regs);
 		of_node_put(np);
 	}
+
+	np = of_find_compatible_node(NULL, NULL, "fsl,mpc8323-qe-usb");
+	if (np) {
+		const char *mode = of_get_property(np, "mode", NULL);
+
+		par_io_config_pin(1,  2, 1, 0, 3, 0); /* USBOE  */
+		par_io_config_pin(1,  3, 1, 0, 3, 0); /* USBTP  */
+		par_io_config_pin(1,  8, 1, 0, 1, 0); /* USBTN  */
+		par_io_config_pin(1, 10, 2, 0, 3, 0); /* USBRXD */
+		par_io_config_pin(1,  9, 2, 1, 3, 0); /* USBRP  */
+		par_io_config_pin(1, 11, 2, 1, 3, 0); /* USBRN  */
+		par_io_config_pin(2, 20, 2, 0, 1, 0); /* CLK21  */
+
+#define BCSR13_USBMASK	0x0f
+#define BCSR13_nUSBEN	0x08 /* 1 - Disable, 0 - Enable			*/
+#define BCSR13_USBSPEED 0x04 /* 1 - Full, 0 - Low			*/
+#define BCSR13_USBMODE	0x02 /* 1 - Host, 0 - Function			*/
+#define BCSR13_nUSBVCC	0x01 /* 1 - gets VBUS, 0 - supplies VBUS 	*/
+
+		clrsetbits_8(&bcsr_regs[13], BCSR13_USBMASK, BCSR13_USBSPEED);
+
+		if (mode && !strcmp(mode, "peripheral"))
+			setbits8(&bcsr_regs[13], BCSR13_nUSBVCC);
+		else
+			setbits8(&bcsr_regs[13], BCSR13_USBMODE);
+
+		of_node_put(np);
+	}
+
+	iounmap(bcsr_regs);
 #endif				/* CONFIG_QUICC_ENGINE */
 }
 
-- 
1.5.6.3

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [RFC PATCH 2/2] powerpc/83xx: mpc836x_mds: add support for USB Host
  2008-08-25 15:27 [RFC PATCH 2/2] powerpc/83xx: mpc836x_mds: add support for USB Host Anton Vorontsov
@ 2008-08-26  5:24 ` David Gibson
  2008-09-01 13:34 ` [RFC PATCH 2/2 v2] " Anton Vorontsov
  1 sibling, 0 replies; 5+ messages in thread
From: David Gibson @ 2008-08-26  5:24 UTC (permalink / raw)
  To: Anton Vorontsov; +Cc: linuxppc-dev, Li Yang

On Mon, Aug 25, 2008 at 07:27:36PM +0400, Anton Vorontsov wrote:
> Various changes to support QE USB Host on a MPC8360E-MDS board:
> 
> - Update the device tree per QE USB bindings;
> - Configure QE Par IO;
> - Set up BCSR for both USB Host and Peripheral modes;
> - Add timer (GTM) node;
> - Add gpio-controller node for BCSR13 bank;
> - Select FSL_GTM, QE_GPIO and OF_SIMPLE_GPIO.
> 
> The work is loosely based on Li Yang's patch[1], which is used
> to support peripheral mode only.
> 
> [1] http://ozlabs.org/pipermail/linuxppc-dev/2008-August/061357.html
> 
> The s-o-b line of the original patch preserved here.
> 
> Signed-off-by: Li Yang <leoli@freescale.com>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
>  arch/powerpc/boot/dts/mpc836x_mds.dts     |   44 +++++++++++++++++++++++++++-
>  arch/powerpc/platforms/83xx/Kconfig       |    3 ++
>  arch/powerpc/platforms/83xx/mpc836x_mds.c |   31 +++++++++++++++++++-
>  3 files changed, 75 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/powerpc/boot/dts/mpc836x_mds.dts b/arch/powerpc/boot/dts/mpc836x_mds.dts
> index ada8446..0be98f3 100644
> --- a/arch/powerpc/boot/dts/mpc836x_mds.dts
> +++ b/arch/powerpc/boot/dts/mpc836x_mds.dts
> @@ -69,8 +69,19 @@
>  		};
>  
>  		bcsr@1,0 {
> +			#address-cells = <1>;
> +			#size-cells = <1>;
>  			device_type = "board-control";

Not the fault of this patch, obviously, but this device_type should
never have been here.

>  			reg = <1 0 0x8000>;
> +			ranges = <0 1 0 0x8000>;
> +
> +			bcsr13: gpio-controller@d {
> +				#gpio-cells = <2>;
> +				compatible = "fsl,mpc8360mds-bcsr-gpio",
> +					     "simple-gpio-bank";
> +				reg = <0xd 1>;
> +				gpio-controller;
> +			};
>  		};
>  	};
>  
> @@ -191,10 +202,21 @@
>  		};
>  
>  		par_io@1400 {
> +			#address-cells = <1>;
> +			#size-cells = <1>;
>  			reg = <0x1400 0x100>;
> +			ranges = <0 0x1400 0x100>;
>  			device_type = "par_io";

Nor this one

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [RFC PATCH 2/2 v2] powerpc/83xx: mpc836x_mds: add support for USB Host
  2008-08-25 15:27 [RFC PATCH 2/2] powerpc/83xx: mpc836x_mds: add support for USB Host Anton Vorontsov
  2008-08-26  5:24 ` David Gibson
@ 2008-09-01 13:34 ` Anton Vorontsov
  2008-09-04  6:45   ` [RFC PATCH 2/2 v2] powerpc/83xx: mpc836x_mds: add support for USBHost Li Yang-R58472
  1 sibling, 1 reply; 5+ messages in thread
From: Anton Vorontsov @ 2008-09-01 13:34 UTC (permalink / raw)
  To: Kumar Gala; +Cc: linuxppc-dev, Li Yang

Various changes to support QE USB Host on a MPC8360E-MDS board:

- Update the device tree per QE USB bindings;
- Configure QE Par IO;
- Set up BCSR for both USB Host and Peripheral modes;
- Add timer (GTM) node;
- Add gpio-controller node for BCSR13 bank;
- Select FSL_GTM, QE_GPIO and OF_SIMPLE_GPIO.

The work is loosely based on Li Yang's patch[1], which is used
to support peripheral mode only.

[1] http://ozlabs.org/pipermail/linuxppc-dev/2008-August/061357.html

The s-o-b line of the original patch preserved here.

Signed-off-by: Li Yang <leoli@freescale.com>
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---

v2:
- We should bring TSECs to RGMII mode, the hunk was missing.

 arch/powerpc/boot/dts/mpc836x_mds.dts     |   44 +++++++++++++++++++++++++++-
 arch/powerpc/platforms/83xx/Kconfig       |    3 ++
 arch/powerpc/platforms/83xx/mpc836x_mds.c |   43 +++++++++++++++++++++++++++-
 3 files changed, 87 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/boot/dts/mpc836x_mds.dts b/arch/powerpc/boot/dts/mpc836x_mds.dts
index ada8446..0be98f3 100644
--- a/arch/powerpc/boot/dts/mpc836x_mds.dts
+++ b/arch/powerpc/boot/dts/mpc836x_mds.dts
@@ -69,8 +69,19 @@
 		};
 
 		bcsr@1,0 {
+			#address-cells = <1>;
+			#size-cells = <1>;
 			device_type = "board-control";
 			reg = <1 0 0x8000>;
+			ranges = <0 1 0 0x8000>;
+
+			bcsr13: gpio-controller@d {
+				#gpio-cells = <2>;
+				compatible = "fsl,mpc8360mds-bcsr-gpio",
+					     "simple-gpio-bank";
+				reg = <0xd 1>;
+				gpio-controller;
+			};
 		};
 	};
 
@@ -191,10 +202,21 @@
 		};
 
 		par_io@1400 {
+			#address-cells = <1>;
+			#size-cells = <1>;
 			reg = <0x1400 0x100>;
+			ranges = <0 0x1400 0x100>;
 			device_type = "par_io";
 			num-ports = <7>;
 
+			qe_pio_b: gpio-controller@18 {
+				#gpio-cells = <2>;
+				compatible = "fsl,mpc8360-qe-pario-bank",
+					     "fsl,mpc8323-qe-pario-bank";
+				reg = <0x18 0x18>;
+				gpio-controller;
+			};
+
 			pio1: ucc_pin@01 {
 				pio-map = <
 			/* port  pin  dir  open_drain  assignment  has_irq */
@@ -278,6 +300,15 @@
 			};
 		};
 
+		timer@440 {
+			compatible = "fsl,mpc8360-qe-gtm",
+				     "fsl,qe-gtm", "fsl,gtm";
+			reg = <0x440 0x40>;
+			clock-frequency = <132000000>;
+			interrupts = <12 13 14 15>;
+			interrupt-parent = <&qeic>;
+		};
+
 		spi@4c0 {
 			cell-index = <0>;
 			compatible = "fsl,spi";
@@ -297,11 +328,20 @@
 		};
 
 		usb@6c0 {
-			compatible = "qe_udc";
+			compatible = "fsl,mpc8360-qe-usb",
+				     "fsl,mpc8323-qe-usb";
 			reg = <0x6c0 0x40 0x8b00 0x100>;
 			interrupts = <11>;
 			interrupt-parent = <&qeic>;
-			mode = "slave";
+			fsl,fullspeed-clock = "clk21";
+			fsl,lowspeed-clock = "brg9";
+			gpios = <&qe_pio_b  2 0   /* USBOE */
+				 &qe_pio_b  3 0   /* USBTP */
+				 &qe_pio_b  8 0   /* USBTN */
+				 &qe_pio_b  9 0   /* USBRP */
+				 &qe_pio_b 11 0   /* USBRN */
+				 &bcsr13    5 0   /* SPEED */
+				 &bcsr13    4 1>; /* POWER */
 		};
 
 		enet0: ucc@2000 {
diff --git a/arch/powerpc/platforms/83xx/Kconfig b/arch/powerpc/platforms/83xx/Kconfig
index 6159c5d..558458d 100644
--- a/arch/powerpc/platforms/83xx/Kconfig
+++ b/arch/powerpc/platforms/83xx/Kconfig
@@ -58,6 +58,9 @@ config MPC836x_MDS
 	bool "Freescale MPC836x MDS"
 	select DEFAULT_UIMAGE
 	select QUICC_ENGINE
+	select QE_GPIO
+	select OF_SIMPLE_GPIO
+	select FSL_GTM
 	help
 	  This option enables support for the MPC836x MDS Processor Board.
 
diff --git a/arch/powerpc/platforms/83xx/mpc836x_mds.c b/arch/powerpc/platforms/83xx/mpc836x_mds.c
index 9d46e5b..e04fc57 100644
--- a/arch/powerpc/platforms/83xx/mpc836x_mds.c
+++ b/arch/powerpc/platforms/83xx/mpc836x_mds.c
@@ -127,9 +127,50 @@ static void __init mpc836x_mds_setup_arch(void)
 			iounmap(immap);
 		}
 
-		iounmap(bcsr_regs);
 		of_node_put(np);
 	}
+
+	np = of_find_compatible_node(NULL, NULL, "fsl,mpc8323-qe-usb");
+	if (np) {
+		const char *mode = of_get_property(np, "mode", NULL);
+
+		par_io_config_pin(1,  2, 1, 0, 3, 0); /* USBOE  */
+		par_io_config_pin(1,  3, 1, 0, 3, 0); /* USBTP  */
+		par_io_config_pin(1,  8, 1, 0, 1, 0); /* USBTN  */
+		par_io_config_pin(1, 10, 2, 0, 3, 0); /* USBRXD */
+		par_io_config_pin(1,  9, 2, 1, 3, 0); /* USBRP  */
+		par_io_config_pin(1, 11, 2, 1, 3, 0); /* USBRN  */
+		par_io_config_pin(2, 20, 2, 0, 1, 0); /* CLK21  */
+
+#define BCSR8_TSEC1M_MASK	(0x3 << 6)
+#define BCSR8_TSEC1M_RGMII	(0x0 << 6)
+#define BCSR8_TSEC2M_MASK	(0x3 << 4)
+#define BCSR8_TSEC2M_RGMII	(0x0 << 4)
+		/*
+		 * Default is GMII (2), but we should set it to RGMII (0) if
+		 * we use USB (Eth PHY is in RGMII mode anyway).
+		 */
+		clrsetbits_8(&bcsr_regs[8],
+			     BCSR8_TSEC1M_MASK | BCSR8_TSEC2M_MASK,
+			     BCSR8_TSEC1M_RGMII | BCSR8_TSEC2M_RGMII);
+
+#define BCSR13_USBMASK	0x0f
+#define BCSR13_nUSBEN	0x08 /* 1 - Disable, 0 - Enable			*/
+#define BCSR13_USBSPEED 0x04 /* 1 - Full, 0 - Low			*/
+#define BCSR13_USBMODE	0x02 /* 1 - Host, 0 - Function			*/
+#define BCSR13_nUSBVCC	0x01 /* 1 - gets VBUS, 0 - supplies VBUS 	*/
+
+		clrsetbits_8(&bcsr_regs[13], BCSR13_USBMASK, BCSR13_USBSPEED);
+
+		if (mode && !strcmp(mode, "peripheral"))
+			setbits8(&bcsr_regs[13], BCSR13_nUSBVCC);
+		else
+			setbits8(&bcsr_regs[13], BCSR13_USBMODE);
+
+		of_node_put(np);
+	}
+
+	iounmap(bcsr_regs);
 #endif				/* CONFIG_QUICC_ENGINE */
 }
 
-- 
1.5.6.3

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* RE: [RFC PATCH 2/2 v2] powerpc/83xx: mpc836x_mds: add support for USBHost
  2008-09-01 13:34 ` [RFC PATCH 2/2 v2] " Anton Vorontsov
@ 2008-09-04  6:45   ` Li Yang-R58472
  2008-09-04 12:22     ` Anton Vorontsov
  0 siblings, 1 reply; 5+ messages in thread
From: Li Yang-R58472 @ 2008-09-04  6:45 UTC (permalink / raw)
  To: avorontsov, Kumar Gala; +Cc: linuxppc-dev

> -----Original Message-----
> From: Anton Vorontsov [mailto:avorontsov@ru.mvista.com]=20
> Sent: Monday, September 01, 2008 9:35 PM
> To: Kumar Gala
> Cc: linuxppc-dev@ozlabs.org; Li Yang-R58472
> Subject: [RFC PATCH 2/2 v2] powerpc/83xx: mpc836x_mds: add=20
> support for USBHost
>=20
> Various changes to support QE USB Host on a MPC8360E-MDS board:
>=20
> - Update the device tree per QE USB bindings;
> - Configure QE Par IO;
> - Set up BCSR for both USB Host and Peripheral modes;
> - Add timer (GTM) node;
> - Add gpio-controller node for BCSR13 bank;
> - Select FSL_GTM, QE_GPIO and OF_SIMPLE_GPIO.
>=20
> The work is loosely based on Li Yang's patch[1], which is=20
> used to support peripheral mode only.
>=20
> [1] http://ozlabs.org/pipermail/linuxppc-dev/2008-August/061357.html
>=20
> The s-o-b line of the original patch preserved here.
>=20
> Signed-off-by: Li Yang <leoli@freescale.com>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>

{snip}
> @@ -297,11 +328,20 @@
>  		};
> =20
>  		usb@6c0 {
> -			compatible =3D "qe_udc";
> +			compatible =3D "fsl,mpc8360-qe-usb",
> +				     "fsl,mpc8323-qe-usb";
>  			reg =3D <0x6c0 0x40 0x8b00 0x100>;
>  			interrupts =3D <11>;
>  			interrupt-parent =3D <&qeic>;
> -			mode =3D "slave";
> +			fsl,fullspeed-clock =3D "clk21";
> +			fsl,lowspeed-clock =3D "brg9";
> +			gpios =3D <&qe_pio_b  2 0   /* USBOE */
> +				 &qe_pio_b  3 0   /* USBTP */
> +				 &qe_pio_b  8 0   /* USBTN */
> +				 &qe_pio_b  9 0   /* USBRP */
> +				 &qe_pio_b 11 0   /* USBRN */
> +				 &bcsr13    5 0   /* SPEED */
> +				 &bcsr13    4 1>; /* POWER */


Nothing against this node.  But I don't think gpio nodes can replaces =
par_io nodes.  Gpios are focusing on the pins which are directly =
manipulated by the core, but par_io are for pins used by internal SoCs.

- Leo

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RFC PATCH 2/2 v2] powerpc/83xx: mpc836x_mds: add support for USBHost
  2008-09-04  6:45   ` [RFC PATCH 2/2 v2] powerpc/83xx: mpc836x_mds: add support for USBHost Li Yang-R58472
@ 2008-09-04 12:22     ` Anton Vorontsov
  0 siblings, 0 replies; 5+ messages in thread
From: Anton Vorontsov @ 2008-09-04 12:22 UTC (permalink / raw)
  To: Li Yang-R58472; +Cc: linuxppc-dev

On Thu, Sep 04, 2008 at 02:45:05PM +0800, Li Yang-R58472 wrote:
> > -----Original Message-----
> > From: Anton Vorontsov [mailto:avorontsov@ru.mvista.com] 
> > Sent: Monday, September 01, 2008 9:35 PM
> > To: Kumar Gala
> > Cc: linuxppc-dev@ozlabs.org; Li Yang-R58472
> > Subject: [RFC PATCH 2/2 v2] powerpc/83xx: mpc836x_mds: add 
> > support for USBHost
> > 
> > Various changes to support QE USB Host on a MPC8360E-MDS board:
> > 
> > - Update the device tree per QE USB bindings;
> > - Configure QE Par IO;
> > - Set up BCSR for both USB Host and Peripheral modes;
> > - Add timer (GTM) node;
> > - Add gpio-controller node for BCSR13 bank;
> > - Select FSL_GTM, QE_GPIO and OF_SIMPLE_GPIO.
> > 
> > The work is loosely based on Li Yang's patch[1], which is 
> > used to support peripheral mode only.
> > 
> > [1] http://ozlabs.org/pipermail/linuxppc-dev/2008-August/061357.html
> > 
> > The s-o-b line of the original patch preserved here.
> > 
> > Signed-off-by: Li Yang <leoli@freescale.com>
> > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> 
> {snip}
> > @@ -297,11 +328,20 @@
> >  		};
> >  
> >  		usb@6c0 {
> > -			compatible = "qe_udc";
> > +			compatible = "fsl,mpc8360-qe-usb",
> > +				     "fsl,mpc8323-qe-usb";
> >  			reg = <0x6c0 0x40 0x8b00 0x100>;
> >  			interrupts = <11>;
> >  			interrupt-parent = <&qeic>;
> > -			mode = "slave";
> > +			fsl,fullspeed-clock = "clk21";
> > +			fsl,lowspeed-clock = "brg9";
> > +			gpios = <&qe_pio_b  2 0   /* USBOE */
> > +				 &qe_pio_b  3 0   /* USBTP */
> > +				 &qe_pio_b  8 0   /* USBTN */
> > +				 &qe_pio_b  9 0   /* USBRP */
> > +				 &qe_pio_b 11 0   /* USBRN */
> > +				 &bcsr13    5 0   /* SPEED */
> > +				 &bcsr13    4 1>; /* POWER */
> 
> 
> Nothing against this node.  But I don't think gpio nodes can
> replaces par_io nodes. 

Yes, they can't, and gpios = <> are not meant to be replacement
for par_io nodes. gpios are used by the host driver, the driver
really needs these "gpios = <>" as gpios.

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2008-09-04 12:22 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-25 15:27 [RFC PATCH 2/2] powerpc/83xx: mpc836x_mds: add support for USB Host Anton Vorontsov
2008-08-26  5:24 ` David Gibson
2008-09-01 13:34 ` [RFC PATCH 2/2 v2] " Anton Vorontsov
2008-09-04  6:45   ` [RFC PATCH 2/2 v2] powerpc/83xx: mpc836x_mds: add support for USBHost Li Yang-R58472
2008-09-04 12:22     ` Anton Vorontsov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).