[PATCH] powerpc: Reserve syscall number 319

[PATCH] powerpc: Reserve syscall number 319

[Benjamin Herrenschmidt]

Some stuff I'm working on that isn't released yet needs
a syscall number but I can't say what it's for until I
get permission to release it :-)

In the meantime, it would be nice if a number could be set
aside so the tools being developped to use that stuff don't
all need to be updated when things are eventually released.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---

I wonder if I'll get hanged for that one :-)

 arch/powerpc/include/asm/systbl.h |    1 +
 arch/powerpc/include/asm/unistd.h |    3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

--- linux-work.orig/arch/powerpc/include/asm/systbl.h	2008-09-02 15:14:53.000000000 +1000
+++ linux-work/arch/powerpc/include/asm/systbl.h	2008-09-02 15:14:54.000000000 +1000
@@ -322,3 +322,4 @@ SYSCALL_SPU(epoll_create1)
 SYSCALL_SPU(dup3)
 SYSCALL_SPU(pipe2)
 SYSCALL(inotify_init1)
+SYSCALL(ni_syscall)
Index: linux-work/arch/powerpc/include/asm/unistd.h
===================================================================
--- linux-work.orig/arch/powerpc/include/asm/unistd.h	2008-09-02 15:11:55.000000000 +1000
+++ linux-work/arch/powerpc/include/asm/unistd.h	2008-09-02 15:14:42.000000000 +1000
@@ -341,10 +341,11 @@
 #define __NR_dup3		316
 #define __NR_pipe2		317
 #define __NR_inotify_init1	318
+/* 319 is reserved */
 
 #ifdef __KERNEL__
 
-#define __NR_syscalls		319
+#define __NR_syscalls		320
 
 #define __NR__exit __NR_exit
 #define NR_syscalls	__NR_syscalls

Re: [PATCH] powerpc: Reserve syscall number 319

[Josh Boyer]

On Tue, Sep 02, 2008 at 03:48:45PM +1000, Benjamin Herrenschmidt wrote:
>Some stuff I'm working on that isn't released yet needs
>a syscall number but I can't say what it's for until I
>get permission to release it :-)
>
>In the meantime, it would be nice if a number could be set
>aside so the tools being developped to use that stuff don't
>all need to be updated when things are eventually released.
>
>Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>---
>
>I wonder if I'll get hanged for that one :-)

Is it a powerpc-specific syscall?  If so... ew?

josh

Re: [PATCH] powerpc: Reserve syscall number 319

[Olof Johansson]

On Tue, Sep 02, 2008 at 03:48:45PM +1000, Benjamin Herrenschmidt wrote:
> Some stuff I'm working on that isn't released yet needs
> a syscall number but I can't say what it's for until I
> get permission to release it :-)
> 
> In the meantime, it would be nice if a number could be set
> aside so the tools being developped to use that stuff don't
> all need to be updated when things are eventually released.
> 
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> 
> I wonder if I'll get hanged for that one :-)

Yes. Merge your code or live with the pain of things changing
underneath. Period.


-Olof

Re: [PATCH] powerpc: Reserve syscall number 319

[Benjamin Herrenschmidt]

On Tue, 2008-09-02 at 08:08 -0400, Josh Boyer wrote:
> On Tue, Sep 02, 2008 at 03:48:45PM +1000, Benjamin Herrenschmidt wrote:
> >Some stuff I'm working on that isn't released yet needs
> >a syscall number but I can't say what it's for until I
> >get permission to release it :-)
> >
> >In the meantime, it would be nice if a number could be set
> >aside so the tools being developped to use that stuff don't
> >all need to be updated when things are eventually released.
> >
> >Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> >---
> >
> >I wonder if I'll get hanged for that one :-)
> 
> Is it a powerpc-specific syscall?  If so... ew?

Yes :-)

Ben.

Re: [PATCH] powerpc: Reserve syscall number 319

[Benjamin Herrenschmidt]

On Tue, 2008-09-02 at 13:06 -0500, Olof Johansson wrote:
> On Tue, Sep 02, 2008 at 03:48:45PM +1000, Benjamin Herrenschmidt wrote:
> > Some stuff I'm working on that isn't released yet needs
> > a syscall number but I can't say what it's for until I
> > get permission to release it :-)
> > 
> > In the meantime, it would be nice if a number could be set
> > aside so the tools being developped to use that stuff don't
> > all need to be updated when things are eventually released.
> > 
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > ---
> > 
> > I wonder if I'll get hanged for that one :-)
> 
> Yes. Merge your code or live with the pain of things changing
> underneath. Period.

Pain isn't for me :-) It's for those writing userspace stuff based on
my kernel changing all the time :-)

Ben.

Re: [PATCH] powerpc: Reserve syscall number 319

[Olof Johansson]

On Wed, Sep 03, 2008 at 07:06:15AM +1000, Benjamin Herrenschmidt wrote:
> On Tue, 2008-09-02 at 13:06 -0500, Olof Johansson wrote:
> > On Tue, Sep 02, 2008 at 03:48:45PM +1000, Benjamin Herrenschmidt wrote:
> > > Some stuff I'm working on that isn't released yet needs
> > > a syscall number but I can't say what it's for until I
> > > get permission to release it :-)
> > > 
> > > In the meantime, it would be nice if a number could be set
> > > aside so the tools being developped to use that stuff don't
> > > all need to be updated when things are eventually released.
> > > 
> > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > > ---
> > > 
> > > I wonder if I'll get hanged for that one :-)
> > 
> > Yes. Merge your code or live with the pain of things changing
> > underneath. Period.
> 
> Pain isn't for me :-) It's for those writing userspace stuff based on
> my kernel changing all the time :-)

Lame excuse. Merge the code.


-Olof

Re: [PATCH] powerpc: Reserve syscall number 319

[Benjamin Herrenschmidt]

On Tue, 2008-09-02 at 16:30 -0500, Olof Johansson wrote:
> On Wed, Sep 03, 2008 at 07:06:15AM +1000, Benjamin Herrenschmidt wrote:
> > On Tue, 2008-09-02 at 13:06 -0500, Olof Johansson wrote:
> > > On Tue, Sep 02, 2008 at 03:48:45PM +1000, Benjamin Herrenschmidt wrote:
> > > > Some stuff I'm working on that isn't released yet needs
> > > > a syscall number but I can't say what it's for until I
> > > > get permission to release it :-)
> > > > 
> > > > In the meantime, it would be nice if a number could be set
> > > > aside so the tools being developped to use that stuff don't
> > > > all need to be updated when things are eventually released.
> > > > 
> > > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > > > ---
> > > > 
> > > > I wonder if I'll get hanged for that one :-)
> > > 
> > > Yes. Merge your code or live with the pain of things changing
> > > underneath. Period.
> > 
> > Pain isn't for me :-) It's for those writing userspace stuff based on
> > my kernel changing all the time :-)
> 
> Lame excuse. Merge the code.

man, you know as well as I do I can't do that before the lawyers let
me :-)

Ben.

Re: [PATCH] powerpc: Reserve syscall number 319

[Olof Johansson]

On Wed, Sep 03, 2008 at 07:49:10AM +1000, Benjamin Herrenschmidt wrote:
> On Tue, 2008-09-02 at 16:30 -0500, Olof Johansson wrote:
> > On Wed, Sep 03, 2008 at 07:06:15AM +1000, Benjamin Herrenschmidt wrote:
> > > On Tue, 2008-09-02 at 13:06 -0500, Olof Johansson wrote:
> > > > On Tue, Sep 02, 2008 at 03:48:45PM +1000, Benjamin Herrenschmidt wrote:
> > > > > Some stuff I'm working on that isn't released yet needs
> > > > > a syscall number but I can't say what it's for until I
> > > > > get permission to release it :-)
> > > > > 
> > > > > In the meantime, it would be nice if a number could be set
> > > > > aside so the tools being developped to use that stuff don't
> > > > > all need to be updated when things are eventually released.
> > > > > 
> > > > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > > > > ---
> > > > > 
> > > > > I wonder if I'll get hanged for that one :-)
> > > > 
> > > > Yes. Merge your code or live with the pain of things changing
> > > > underneath. Period.
> > > 
> > > Pain isn't for me :-) It's for those writing userspace stuff based on
> > > my kernel changing all the time :-)
> > 
> > Lame excuse. Merge the code.
> 
> man, you know as well as I do I can't do that before the lawyers let
> me :-)

Then don't try to reserve a system call to be used only by an out-of-tree,
proprietary kernel extension. Which your kernel change in essence is
until it's released.

Would we accept a system call number reservation that was submitted by,
say, nVidia? No? Well, there you go.

It's really that simple.


-Olof

Re: [PATCH] powerpc: Reserve syscall number 319

[Benjamin Herrenschmidt]

> Then don't try to reserve a system call to be used only by an out-of-tree,
> proprietary kernel extension. Which your kernel change in essence is
> until it's released.
> 
> Would we accept a system call number reservation that was submitted by,
> say, nVidia? No? Well, there you go.
> 
> It's really that simple.

Well, except that nvidia has no intention to release :-)

Anyway, it's a moot point, I have the answer I needed...

Cheers,
Ben.

Re: [PATCH] powerpc: Reserve syscall number 319

[Christoph Hellwig]

On Wed, Sep 03, 2008 at 07:06:15AM +1000, Benjamin Herrenschmidt wrote:
> > Yes. Merge your code or live with the pain of things changing
> > underneath. Period.
> 
> Pain isn't for me :-) It's for those writing userspace stuff based on
> my kernel changing all the time :-)

They can wait until it's released.  And there's of course no guarantee
that your syscall will stand public review.

Re: [PATCH] powerpc: Reserve syscall number 319

[Benjamin Herrenschmidt]

On Wed, 2008-09-03 at 01:46 +0200, Christoph Hellwig wrote:
> On Wed, Sep 03, 2008 at 07:06:15AM +1000, Benjamin Herrenschmidt wrote:
> > > Yes. Merge your code or live with the pain of things changing
> > > underneath. Period.
> > 
> > Pain isn't for me :-) It's for those writing userspace stuff based on
> > my kernel changing all the time :-)
> 
> They can wait until it's released.  And there's of course no guarantee
> that your syscall will stand public review.

Yup. Definitely. I'm not even 100% sure we'll stick to a syscall in
the long run. In the meantime, for internal purposes, it's easy enough
to use an unused number to avoid further changes or stick a trampoline
in the vdso :-)

Cheers,
Ben.