From: Martyn Welch <martyn.welch@gefanuc.com>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH v4 1/2] powerpc: Board support for GE Fanuc SBC610
Date: Thu, 4 Sep 2008 15:51:27 +0100 [thread overview]
Message-ID: <20080904155127.5ca8fca3.martyn.welch@gefanuc.com> (raw)
In-Reply-To: <20080902182709.GB16741@ld0162-tx32.am.freescale.net>
On Tue, 2 Sep 2008 13:27:09 -0500
Scott Wood <scottwood@freescale.com> wrote:
> On Mon, Sep 01, 2008 at 11:27:59AM +0100, Martyn Welch wrote:
> > +static __initdata struct of_device_id of_bus_ids[] = {
> > + { .compatible = "simple-bus", },
> > + { .type = "serial", },
> > + { .type = "soc", },
> > + { .type = "i2c", },
>
> i2c and serial don't belong here, and soc is redundant with simple-bus.
>
I agree about the i2c and serial, although I need the soc entry for the i2c devices to be found during the platform scan.
Martyn
> -Scott
--
Martyn Welch MEng MPhil MIET (Principal Software Engineer) T:+44(0)1327322748
GE Fanuc Intelligent Platforms Ltd, |Registered in England and Wales
Tove Valley Business Park, Towcester, |(3828642) at 100 Barbirolli Square,
Northants, NN12 6PF, UK T:+44(0)1327359444 |Manchester,M2 3AB VAT:GB 729849476
next prev parent reply other threads:[~2008-09-04 14:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 10:27 [PATCH v4 0/2] powerpc: Board support for GE Fanuc SBC610 Martyn Welch
2008-09-01 10:27 ` [PATCH v4 1/2] " Martyn Welch
2008-09-02 18:27 ` Scott Wood
2008-09-04 8:17 ` Martyn Welch
2008-09-04 14:51 ` Martyn Welch [this message]
2008-09-04 15:04 ` Scott Wood
2008-09-04 15:34 ` Martyn Welch
2008-09-01 10:28 ` [PATCH v4 2/2] powerpc: Default configuration " Martyn Welch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080904155127.5ca8fca3.martyn.welch@gefanuc.com \
--to=martyn.welch@gefanuc.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).