From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e2.ny.us.ibm.com (e2.ny.us.ibm.com [32.97.182.142]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "e2.ny.us.ibm.com", Issuer "Equifax" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 7855BDDF20 for ; Fri, 5 Sep 2008 13:37:36 +1000 (EST) Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e2.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id m853bWmD024066 for ; Thu, 4 Sep 2008 23:37:32 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m853bWer239788 for ; Thu, 4 Sep 2008 23:37:32 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m853bWQ4030068 for ; Thu, 4 Sep 2008 23:37:32 -0400 Date: Thu, 4 Sep 2008 23:37:24 -0400 From: Josh Boyer To: benh@kernel.crashing.org Subject: Re: [PATCH 2/3] ibm_newemac: Introduce mal_has_feature Message-ID: <20080904233724.1115dd54@zod.rchland.ibm.com> In-Reply-To: <1220584763.4879.97.camel@pasglop> References: <20080904150205.GC2479@yoda.jdub.homelinux.org> <1220584763.4879.97.camel@pasglop> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: netdev@vger.kernel.org, linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 05 Sep 2008 13:19:23 +1000 Benjamin Herrenschmidt wrote: > On Thu, 2008-09-04 at 11:02 -0400, Josh Boyer wrote: > > There are some PowerPC SoCs that do odd things with the MAL handling. In > > order to accommodate them, we need to introduce a feature mechanism that is > > similar to the existing emac_has_feature function. > > > > This adds a feature variable to the mal_instance structure, and adds a > > mal_has_feature function with some feature definitions. These are guarded > > by Kconfig options that are selected by the affected platforms. > > > > Signed-of-by: Josh Boyer > > You also add an actual feature (CLR_ICINSTAT). You should document that > or move it to a separate patch. I add two features. And I so in the commit log, though I didn't actually say what those do. I can fix that up. > > > +/* Features of various MAL implementations */ > > + > > +/* Dummy feature bit so the enum works properly */ > > +#define MAL_FTR_DUMMY 0x00000001 > > Nah. Just stick an | 0 in the enum to make it happy. OK. I did that originally, but for some reason I wanted to avoid having FTRS_ALWAYS and FTRS_POSSIBLE be equal if none of the Kconfig options were set. I can't remember why though. josh