From: Sean MacLennan <smaclennan@pikatech.com>
To: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc/44x: Add hwmon support to Sequoia device tree
Date: Fri, 5 Sep 2008 20:17:03 -0400 [thread overview]
Message-ID: <20080905201703.0586e131@lappy.seanm.ca> (raw)
In-Reply-To: <20080905160017.GA22310@ld0162-tx32.am.freescale.net>
On Fri, 5 Sep 2008 11:00:18 -0500
"Scott Wood" <scottwood@freescale.com> wrote:
> On Fri, Sep 05, 2008 at 12:19:43PM +0200, Stefan Roese wrote:
> > > +
> > > + hwmon@48 {
> >
> > Not sure if we shouldn't use
> >
> > ad7414@48 {
> >
> > here. This is the way it is already done in warp.dts.
>
> We shouldn't. Node names are supposed to be generic:
> http://playground.sun.com/1275/practice/gnames/gnamv14a.html
Damn. Where were you a year ago when I first introduced this? ;)
And if it is really supposed to be generic, would temp@48 be a
better name since this is basically a generic temperature chip?
Now that the i2c driver is a full of platform driver, I think I
can change the name with no repercussions. So I can live with whatever
decision is made. Can't do anything about the systems that are out in
the field though....
Cheers,
Sean
next prev parent reply other threads:[~2008-09-06 3:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-04 9:55 [RFC] adding hwmon support to sequoia device tree Matthias Fuchs
2008-09-04 12:25 ` Josh Boyer
2008-09-04 12:50 ` Stefan Roese
2008-09-04 14:28 ` Matthias Fuchs
2008-09-04 14:41 ` [PATCH] powerpc/44x: Add hwmon support to Sequoia " Matthias Fuchs
2008-09-05 10:19 ` Stefan Roese
2008-09-05 14:58 ` Matthias Fuchs
2008-09-05 16:00 ` Scott Wood
2008-09-06 0:17 ` Sean MacLennan [this message]
2008-09-06 12:07 ` Josh Boyer
2008-09-08 7:57 ` [PATCH V2] " Matthias Fuchs
2008-09-06 12:40 ` [PATCH] " Matthias Fuchs
2008-09-06 11:49 ` Sean MacLennan
2008-09-06 15:07 ` Wolfgang Grandegger
2008-09-08 16:03 ` Scott Wood
2008-09-09 11:52 ` Matthias Fuchs
2008-09-09 12:15 ` Josh Boyer
2008-09-05 14:27 ` [RFC] adding hwmon support to sequoia " Sean MacLennan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080905201703.0586e131@lappy.seanm.ca \
--to=smaclennan@pikatech.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).