Question on 4xx GIT tree

Question on 4xx GIT tree

[Prodyut Hazarika]

Hi Josh,
I am planning to submit a patch to support 4K/16K and 64K page size for =
4xx processors.
I see that your git tree still has the include/asm-powerpc/* header =
files, while in Linus's git tree, the powerpc specific header file has =
been moved to arch/powerpc/include/asm.

Should I base my patch from your git tree or Linus's git tree? Please =
advice how to proceed since I want your efforts in merging as painless =
as possible.

Regards,
Prodyut Hazarika

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
Staff S/w Engineer
AMCC
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

Re: Question on 4xx GIT tree

[Josh Boyer]

On Mon, 8 Sep 2008 13:55:26 -0700
"Prodyut Hazarika" <phazarika@amcc.com> wrote:

> Hi Josh,
> I am planning to submit a patch to support 4K/16K and 64K page size for 4xx processors.
> I see that your git tree still has the include/asm-powerpc/* header files, while in Linus's git tree, the powerpc specific header file has been moved to arch/powerpc/include/asm.

I assume you're looking at my master branch.  That was a bit old and
I've updated it now to match the overall powerpc.git tree master
branch.  Sorry about that, I'll be a bit more diligent in keeping it
updated from now on.

> Should I base my patch from your git tree or Linus's git tree? Please advice how to proceed since I want your efforts in merging as painless as possible.

Generally, if you track my 'next' branch that is what will be most
current for 4xx.  It contains patches that aren't anywhere else at the
moment.

josh

RE: Question on 4xx GIT tree

[Prodyut Hazarika]

Hi Josh,
Thanks for your reply.

> That was a bit old and I've updated it now to match the =
overallpowerpc.git tree master branch
Thanks. I can see the changes now.

> Generally, if you track my 'next' branch that is what will be most =
current for 4xxjosh
Should I base my patch from your master branch or your 'next' branch?

Regards,
Prodyut Hazarika

Re: Question on 4xx GIT tree

[Josh Boyer]

On Mon, 8 Sep 2008 14:42:33 -0700
"Prodyut Hazarika" <phazarika@amcc.com> wrote:

> Hi Josh,
> Thanks for your reply.
> 
> > That was a bit old and I've updated it now to match the overallpowerpc.git tree master branch
> Thanks. I can see the changes now.
> 
> > Generally, if you track my 'next' branch that is what will be most current for 4xxjosh
> Should I base my patch from your master branch or your 'next' branch?

The 'next' branch would be best.

josh

RE: Question on 4xx GIT tree

[Prodyut Hazarika]

Hi Josh,
I have few questions.

> > Should I base my patch from your master branch or your 'next' =
branch?
> The 'next' branch would be best.

I saw that both your master and next branches have removed the 4xx dma =
and USB drivers.
The dma drivers for 4xx used to under: drivers/dma/ppc440spe-adma.c
The usb driver for 4xx used to be under: drivers/usb/gadget/dwc_otg/*
The whole dwc_otg directory got removed.

Do you know the reason why these drivers were removed? Also, are there =
plans to get these drivers back?
Please let me know.

Regards,
Prodyut Hazarika

Re: Question on 4xx GIT tree

[Josh Boyer]

On Wed, 10 Sep 2008 16:47:48 -0700
"Prodyut Hazarika" <phazarika@amcc.com> wrote:

> Hi Josh,
> I have few questions.
> 
> > > Should I base my patch from your master branch or your 'next' branch?
> > The 'next' branch would be best.
> 
> I saw that both your master and next branches have removed the 4xx dma and USB drivers.
> The dma drivers for 4xx used to under: drivers/dma/ppc440spe-adma.c
> The usb driver for 4xx used to be under: drivers/usb/gadget/dwc_otg/*
> The whole dwc_otg directory got removed.

Those drivers were never in any version of the upstream kernel
according to git.

[jwboyer@yoda linux-2.6]$ git checkout master
Switched to branch "master"
[jwboyer@yoda linux-2.6]$ git log -- drivers/dma/ppc440spe-adma.c
[jwboyer@yoda linux-2.6]$ git log -- drivers/usb/gadget/dwc_otg
[jwboyer@yoda linux-2.6]$

> Do you know the reason why these drivers were removed? Also, are there plans to get these drivers back?
> Please let me know.

Perhaps they are in the DENX kernel?  If so, someone would need to
submit them for inclusion.

josh

RE: Question on 4xx GIT tree

[Prodyut Hazarika]

Hi Josh,

> > Do you know the reason why these drivers were removed? Also, are =
there plans to get these drivers back?
> > Please let me know.

> Perhaps they are in the DENX kernel?  If so, someone would need to =
submit them for inclusion.

Yes those drivers were in the Denx kernel. I was in the impression that =
they were in the mainline Linux tree too. I will try to get those =
drivers submitted to the main Linux tree.

Thanks for your clarifications.

Regards,
Prodyut Hazarika

Re: Question on 4xx GIT tree

[Stefan Roese]

On Thursday 11 September 2008, Prodyut Hazarika wrote:
> > > Do you know the reason why these drivers were removed? Also, are there
> > > plans to get these drivers back? Please let me know.
> >
> > Perhaps they are in the DENX kernel?  If so, someone would need to submit
> > them for inclusion.
>
> Yes those drivers were in the Denx kernel.

Correct.

> I was in the impression that 
> they were in the mainline Linux tree too. I will try to get those drivers 
> submitted to the main Linux tree.

Great. But prepare for a lot of work to get the USB OTG driver into shape for 
upstream acceptance.

Best regards,
Stefan