linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: Sebastian Siewior <linuxppc-embedded@ml.breakpoint.cc>
Cc: Ayman El-Khashab <AymanE@tanisys.com>,
	devicetree-discuss@ozlabs.org, Linuxppc-embedded@ozlabs.org
Subject: Re: Device tree configuration for I2C eeprom
Date: Fri, 19 Sep 2008 00:44:58 -0700	[thread overview]
Message-ID: <20080919074458.GA7602@secretlab.ca> (raw)
In-Reply-To: <20080919071238.GA8773@Chamillionaire.breakpoint.cc>

On Fri, Sep 19, 2008 at 09:12:38AM +0200, Sebastian Siewior wrote:
> * Grant Likely | 2008-09-18 22:04:41 [-0700]:
> 
> >No, don't use the generic chip names.  Device tree convention is to be
> >specific and prefix the part number with the vendor name.  ie. You should
> >be using "at,at24c64", not "24c64".
> 
> What about the i2c drivers which don't have any prefix like the m41t80?
> Prior commit 0d1cde2 aka "powerpc/i2c: Convert i2c-mpc into an
> of_platform driver" the ids were converted.

Important Concept:  If the driver can't match with nodes that conform with
the device tree binding conventions, then it is a *Linux/device driver* bug;
not a device tree bug.  The device tree describes hardware.  It does not
describe the device driver implementation.

Do not fall into the temptation of writing the device tree to reflect
the current implementation of the operating system.  Stick to
established conventions and documented bindings.

That being said, it is a non-issue in this case.  The current Linux OF
support code automagically strips off the manufacturer prefix when
registering I2C devices.  Take a look at of_modalias_node() in
drivers/of/base.c for details.

g.

  reply	other threads:[~2008-09-19  7:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-18 19:44 Device tree configuration for I2C eeprom Ayman El-Khashab
2008-09-18 22:13 ` Sebastian Siewior
2008-09-18 22:21   ` Jon Smirl
2008-09-19  5:04     ` Grant Likely
2008-09-19  7:12       ` Sebastian Siewior
2008-09-19  7:44         ` Grant Likely [this message]
2008-09-19  8:12           ` Sebastian Siewior
2008-11-04 16:28         ` Grant Likely
2008-11-04 16:29           ` Grant Likely
2008-11-04 17:17             ` Sebastian Andrzej Siewior
2008-11-04 16:07       ` Ayman El-Khashab
2008-11-04 16:45         ` Felix Radensky
2008-11-04 19:52           ` Ayman El-Khashab
2008-11-04 20:04             ` Felix Radensky
2008-11-04 21:00               ` Ayman El-Khashab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080919074458.GA7602@secretlab.ca \
    --to=grant.likely@secretlab.ca \
    --cc=AymanE@tanisys.com \
    --cc=Linuxppc-embedded@ozlabs.org \
    --cc=devicetree-discuss@ozlabs.org \
    --cc=linuxppc-embedded@ml.breakpoint.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).