* [PATCH v2] Add AMCC Arches eval board support to platforms/44x
@ 2008-09-18 22:47 Victor Gallardo
2008-09-19 0:01 ` Josh Boyer
2008-09-19 0:01 ` Josh Boyer
0 siblings, 2 replies; 7+ messages in thread
From: Victor Gallardo @ 2008-09-18 22:47 UTC (permalink / raw)
To: linuxppc-dev; +Cc: fkan, Victor Gallardo
Signed-off-by: Victor Gallardo <vgallardo@amcc.com>
---
v2:
- remove arches.c and instead use canyonlands.c
- remove reference to IBM_NEW_EMAC_RGMII for ARCHES config
- remove reference to IBM_NEW_EMAC_ZMII for ARCHES config
- moved reference to IBM_NEW_EMAC_RGMII under CANYONLANDS config
- moved reference to IBM_NEW_EMAC_ZMII under CANYONLANDS config
arch/powerpc/platforms/44x/Kconfig | 18 ++++++++++++++----
arch/powerpc/platforms/44x/Makefile | 1 +
2 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig
index 249ba01..be1bce7 100644
--- a/arch/powerpc/platforms/44x/Kconfig
+++ b/arch/powerpc/platforms/44x/Kconfig
@@ -83,9 +83,23 @@ config CANYONLANDS
select 460EX
select PCI
select PPC4xx_PCI_EXPRESS
+ select IBM_NEW_EMAC_EMAC4
+ select IBM_NEW_EMAC_RGMII
+ select IBM_NEW_EMAC_ZMII
+ select IBM_NEW_EMAC_TAH
help
This option enables support for the AMCC PPC460EX evaluation board.
+config ARCHES
+ bool "Arches"
+ depends on 44x
+ default n
+ select 460EX
+ select IBM_NEW_EMAC_EMAC4
+ select IBM_NEW_EMAC_TAH
+ help
+ This option enables support for the AMCC PPC460GT evaluation board.
+
config YOSEMITE
bool "Yosemite"
depends on 44x
@@ -169,10 +183,6 @@ config 440SPe
config 460EX
bool
select PPC_FPU
- select IBM_NEW_EMAC_EMAC4
- select IBM_NEW_EMAC_RGMII
- select IBM_NEW_EMAC_ZMII
- select IBM_NEW_EMAC_TAH
# 44x errata/workaround config symbols, selected by the CPU models above
config IBM440EP_ERR42
diff --git a/arch/powerpc/platforms/44x/Makefile b/arch/powerpc/platforms/44x/Makefile
index 8d0b1a1..3f83f73 100644
--- a/arch/powerpc/platforms/44x/Makefile
+++ b/arch/powerpc/platforms/44x/Makefile
@@ -9,5 +9,6 @@ obj-$(CONFIG_KATMAI) += katmai.o
obj-$(CONFIG_RAINIER) += rainier.o
obj-$(CONFIG_WARP) += warp.o
obj-$(CONFIG_WARP) += warp-nand.o
+obj-$(CONFIG_ARCHES) += canyonlands.o
obj-$(CONFIG_CANYONLANDS) += canyonlands.o
obj-$(CONFIG_XILINX_VIRTEX_5_FXT) += virtex.o
--
1.5.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] Add AMCC Arches eval board support to platforms/44x
2008-09-18 22:47 [PATCH v2] Add AMCC Arches eval board support to platforms/44x Victor Gallardo
@ 2008-09-19 0:01 ` Josh Boyer
2008-09-19 0:01 ` Josh Boyer
1 sibling, 0 replies; 7+ messages in thread
From: Josh Boyer @ 2008-09-19 0:01 UTC (permalink / raw)
To: Victor Gallardo; +Cc: linuxppc-dev, Victor Gallardo, fkan
On Thu, 18 Sep 2008 15:47:52 -0700
Victor Gallardo <vgallardo@amcc.com> wrote:
>
> Signed-off-by: Victor Gallardo <vgallardo@amcc.com>
> ---
> v2:
> - remove arches.c and instead use canyonlands.c
That file doesn't exist anymore in my 'next' branch. That is part of
the reason for the original delay. See below.
> - remove reference to IBM_NEW_EMAC_RGMII for ARCHES config
> - remove reference to IBM_NEW_EMAC_ZMII for ARCHES config
> - moved reference to IBM_NEW_EMAC_RGMII under CANYONLANDS config
> - moved reference to IBM_NEW_EMAC_ZMII under CANYONLANDS config
>
> arch/powerpc/platforms/44x/Kconfig | 18 ++++++++++++++----
> arch/powerpc/platforms/44x/Makefile | 1 +
> 2 files changed, 15 insertions(+), 4 deletions(-)
>
> diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig
> index 249ba01..be1bce7 100644
> --- a/arch/powerpc/platforms/44x/Kconfig
> +++ b/arch/powerpc/platforms/44x/Kconfig
> @@ -83,9 +83,23 @@ config CANYONLANDS
> select 460EX
> select PCI
> select PPC4xx_PCI_EXPRESS
> + select IBM_NEW_EMAC_EMAC4
> + select IBM_NEW_EMAC_RGMII
> + select IBM_NEW_EMAC_ZMII
> + select IBM_NEW_EMAC_TAH
> help
> This option enables support for the AMCC PPC460EX evaluation board.
>
> +config ARCHES
> + bool "Arches"
> + depends on 44x
> + default n
> + select 460EX
> + select IBM_NEW_EMAC_EMAC4
> + select IBM_NEW_EMAC_TAH
> + help
> + This option enables support for the AMCC PPC460GT evaluation board.
This seems fine.
> +
> config YOSEMITE
> bool "Yosemite"
> depends on 44x
> @@ -169,10 +183,6 @@ config 440SPe
> config 460EX
> bool
> select PPC_FPU
> - select IBM_NEW_EMAC_EMAC4
> - select IBM_NEW_EMAC_RGMII
> - select IBM_NEW_EMAC_ZMII
> - select IBM_NEW_EMAC_TAH
>
> # 44x errata/workaround config symbols, selected by the CPU models above
> config IBM440EP_ERR42
> diff --git a/arch/powerpc/platforms/44x/Makefile b/arch/powerpc/platforms/44x/Makefile
> index 8d0b1a1..3f83f73 100644
> --- a/arch/powerpc/platforms/44x/Makefile
> +++ b/arch/powerpc/platforms/44x/Makefile
> @@ -9,5 +9,6 @@ obj-$(CONFIG_KATMAI) += katmai.o
> obj-$(CONFIG_RAINIER) += rainier.o
> obj-$(CONFIG_WARP) += warp.o
> obj-$(CONFIG_WARP) += warp-nand.o
> +obj-$(CONFIG_ARCHES) += canyonlands.o
> obj-$(CONFIG_CANYONLANDS) += canyonlands.o
> obj-$(CONFIG_XILINX_VIRTEX_5_FXT) += virtex.o
Instead of modifying the Makefile, you should only have to add the
"amcc,arches" string to the "board" array in ppc44x_simple.c.
We switched to doing this as opposed to having a somewhat bogus "board
compatible" statement with other boards. That is what was discussed at
OLS, and this is the result.
I can probably fix this patch up myself in a short amount of time, but
I have no way to test it.
josh
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] Add AMCC Arches eval board support to platforms/44x
2008-09-18 22:47 [PATCH v2] Add AMCC Arches eval board support to platforms/44x Victor Gallardo
2008-09-19 0:01 ` Josh Boyer
@ 2008-09-19 0:01 ` Josh Boyer
2008-09-19 17:31 ` Victor Gallardo
1 sibling, 1 reply; 7+ messages in thread
From: Josh Boyer @ 2008-09-19 0:01 UTC (permalink / raw)
To: Victor Gallardo; +Cc: linuxppc-dev, Victor Gallardo, fkan
On Thu, 18 Sep 2008 15:47:52 -0700
Victor Gallardo <vgallardo@amcc.com> wrote:
>
> Signed-off-by: Victor Gallardo <vgallardo@amcc.com>
> ---
> v2:
> - remove arches.c and instead use canyonlands.c
That file doesn't exist anymore in my 'next' branch. That is part of
the reason for the original delay. See below.
> - remove reference to IBM_NEW_EMAC_RGMII for ARCHES config
> - remove reference to IBM_NEW_EMAC_ZMII for ARCHES config
> - moved reference to IBM_NEW_EMAC_RGMII under CANYONLANDS config
> - moved reference to IBM_NEW_EMAC_ZMII under CANYONLANDS config
>
> arch/powerpc/platforms/44x/Kconfig | 18 ++++++++++++++----
> arch/powerpc/platforms/44x/Makefile | 1 +
> 2 files changed, 15 insertions(+), 4 deletions(-)
>
> diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig
> index 249ba01..be1bce7 100644
> --- a/arch/powerpc/platforms/44x/Kconfig
> +++ b/arch/powerpc/platforms/44x/Kconfig
> @@ -83,9 +83,23 @@ config CANYONLANDS
> select 460EX
> select PCI
> select PPC4xx_PCI_EXPRESS
> + select IBM_NEW_EMAC_EMAC4
> + select IBM_NEW_EMAC_RGMII
> + select IBM_NEW_EMAC_ZMII
> + select IBM_NEW_EMAC_TAH
> help
> This option enables support for the AMCC PPC460EX evaluation board.
>
> +config ARCHES
> + bool "Arches"
> + depends on 44x
> + default n
> + select 460EX
> + select IBM_NEW_EMAC_EMAC4
> + select IBM_NEW_EMAC_TAH
> + help
> + This option enables support for the AMCC PPC460GT evaluation board.
This seems fine.
> +
> config YOSEMITE
> bool "Yosemite"
> depends on 44x
> @@ -169,10 +183,6 @@ config 440SPe
> config 460EX
> bool
> select PPC_FPU
> - select IBM_NEW_EMAC_EMAC4
> - select IBM_NEW_EMAC_RGMII
> - select IBM_NEW_EMAC_ZMII
> - select IBM_NEW_EMAC_TAH
>
> # 44x errata/workaround config symbols, selected by the CPU models above
> config IBM440EP_ERR42
> diff --git a/arch/powerpc/platforms/44x/Makefile b/arch/powerpc/platforms/44x/Makefile
> index 8d0b1a1..3f83f73 100644
> --- a/arch/powerpc/platforms/44x/Makefile
> +++ b/arch/powerpc/platforms/44x/Makefile
> @@ -9,5 +9,6 @@ obj-$(CONFIG_KATMAI) += katmai.o
> obj-$(CONFIG_RAINIER) += rainier.o
> obj-$(CONFIG_WARP) += warp.o
> obj-$(CONFIG_WARP) += warp-nand.o
> +obj-$(CONFIG_ARCHES) += canyonlands.o
> obj-$(CONFIG_CANYONLANDS) += canyonlands.o
> obj-$(CONFIG_XILINX_VIRTEX_5_FXT) += virtex.o
Instead of modifying the Makefile, you should only have to add the
"amcc,arches" string to the "board" array in ppc44x_simple.c.
We switched to doing this as opposed to having a somewhat bogus "board
compatible" statement with other boards. That is what was discussed at
OLS, and this is the result.
I can probably fix this patch up myself in a short amount of time, but
I have no way to test it.
josh
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH v2] Add AMCC Arches eval board support to platforms/44x
2008-09-19 0:01 ` Josh Boyer
@ 2008-09-19 17:31 ` Victor Gallardo
2008-09-19 17:39 ` Josh Boyer
0 siblings, 1 reply; 7+ messages in thread
From: Victor Gallardo @ 2008-09-19 17:31 UTC (permalink / raw)
To: Josh Boyer; +Cc: linuxppc-dev, Feng Kan
=20
Hi Josh,
See below...
>> ...
>> @@ -83,9 +83,23 @@ config CANYONLANDS
>> select 460EX
>> select PCI
>> select PPC4xx_PCI_EXPRESS
>> + select IBM_NEW_EMAC_EMAC4
>> + select IBM_NEW_EMAC_RGMII
>> + select IBM_NEW_EMAC_ZMII
>> + select IBM_NEW_EMAC_TAH
>> help
>> This option enables support for the AMCC PPC460EX evaluation =
board.
>>=20
>> +config ARCHES
>> + bool "Arches"
>> + depends on 44x
>> + default n
>> + select 460EX
>> + select IBM_NEW_EMAC_EMAC4
>> + select IBM_NEW_EMAC_TAH
>> + help
>> + This option enables support for the AMCC PPC460GT evaluation =
board.
>
>This seems fine.
>
> ...
>
>> +obj-$(CONFIG_ARCHES) +=3D canyonlands.o
>> obj-$(CONFIG_CANYONLANDS) +=3D canyonlands.o
>> obj-$(CONFIG_XILINX_VIRTEX_5_FXT) +=3D virtex.o
>
>Instead of modifying the Makefile, you should only have to add the =
"amcc,arches"
> string to the >"board" array in ppc44x_simple.c.
>
> We switched to doing this as opposed to having a somewhat bogus=20
> "board compatible" statement with >other boards. That is what was =
discussed at
> OLS, and this is the result.
The reason for two different board types is to remove RGMII and ZMII =
from the build. Arches does not use it.
Where is ppc4xx_simple.c? I just pulled your git tree and did not find =
this file.
Thanks,
Victor Gallardo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] Add AMCC Arches eval board support to platforms/44x
2008-09-19 17:31 ` Victor Gallardo
@ 2008-09-19 17:39 ` Josh Boyer
2008-09-22 23:54 ` Victor Gallardo
0 siblings, 1 reply; 7+ messages in thread
From: Josh Boyer @ 2008-09-19 17:39 UTC (permalink / raw)
To: Victor Gallardo; +Cc: linuxppc-dev, Feng Kan
On Fri, 19 Sep 2008 10:31:34 -0700
"Victor Gallardo" <vgallardo@amcc.com> wrote:
>
> Hi Josh,
>
> See below...
>
> >> ...
> >> @@ -83,9 +83,23 @@ config CANYONLANDS
> >> select 460EX
> >> select PCI
> >> select PPC4xx_PCI_EXPRESS
> >> + select IBM_NEW_EMAC_EMAC4
> >> + select IBM_NEW_EMAC_RGMII
> >> + select IBM_NEW_EMAC_ZMII
> >> + select IBM_NEW_EMAC_TAH
> >> help
> >> This option enables support for the AMCC PPC460EX evaluation board.
> >>
> >> +config ARCHES
> >> + bool "Arches"
> >> + depends on 44x
> >> + default n
> >> + select 460EX
> >> + select IBM_NEW_EMAC_EMAC4
> >> + select IBM_NEW_EMAC_TAH
> >> + help
> >> + This option enables support for the AMCC PPC460GT evaluation board.
> >
> >This seems fine.
> >
> > ...
> >
> >> +obj-$(CONFIG_ARCHES) += canyonlands.o
> >> obj-$(CONFIG_CANYONLANDS) += canyonlands.o
> >> obj-$(CONFIG_XILINX_VIRTEX_5_FXT) += virtex.o
> >
> >Instead of modifying the Makefile, you should only have to add the "amcc,arches"
> > string to the >"board" array in ppc44x_simple.c.
> >
> > We switched to doing this as opposed to having a somewhat bogus
> > "board compatible" statement with >other boards. That is what was discussed at
> > OLS, and this is the result.
>
> The reason for two different board types is to remove RGMII and ZMII from the build. Arches does not use it.
Right, and that part is fine.
>
> Where is ppc4xx_simple.c? I just pulled your git tree and did not find this file.
You need to look in the 'next' branch.
http://git.kernel.org/?p=linux/kernel/git/jwboyer/powerpc-4xx.git;a=tree;f=arch/powerpc/platforms/44x;h=c5cae8d37f170193ed45b7b76e3cb2cbb8be927a;hb=next
josh
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2008-09-23 12:21 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-18 22:47 [PATCH v2] Add AMCC Arches eval board support to platforms/44x Victor Gallardo
2008-09-19 0:01 ` Josh Boyer
2008-09-19 0:01 ` Josh Boyer
2008-09-19 17:31 ` Victor Gallardo
2008-09-19 17:39 ` Josh Boyer
2008-09-22 23:54 ` Victor Gallardo
2008-09-23 12:21 ` Josh Boyer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).