* [PATCH] sputrace : use marker_synchronize_unregister() [not found] ` <20080929082722.GB18663@elte.hu> @ 2008-09-29 15:11 ` Mathieu Desnoyers 2008-09-29 15:13 ` Christoph Hellwig 2008-09-30 0:28 ` Jeremy Kerr 0 siblings, 2 replies; 7+ messages in thread From: Mathieu Desnoyers @ 2008-09-29 15:11 UTC (permalink / raw) To: Ingo Molnar Cc: Peter Zijlstra, Linux Kernel Mailing List, Steven Rostedt, Christoph Hellwig, linuxppc-dev, Jeremy Kerr, Andrew Morton, Paul E. McKenney, Lai Jiangshan We need a marker_synchronize_unregister() before the end of exit() to make sure every probe callers have exited the non preemptible section and thus are not executing the probe code anymore. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> CC: Ingo Molnar <mingo@elte.hu> CC: Jeremy Kerr <jk@ozlabs.org> CC: linuxppc-dev@ozlabs.org CC: Christoph Hellwig <hch@infradead.org> --- arch/powerpc/platforms/cell/spufs/sputrace.c | 1 + 1 file changed, 1 insertion(+) Index: linux-2.6-lttng/arch/powerpc/platforms/cell/spufs/sputrace.c =================================================================== --- linux-2.6-lttng.orig/arch/powerpc/platforms/cell/spufs/sputrace.c 2008-07-31 09:34:58.000000000 -0400 +++ linux-2.6-lttng/arch/powerpc/platforms/cell/spufs/sputrace.c 2008-07-31 09:35:15.000000000 -0400 @@ -233,6 +233,7 @@ static void __exit sputrace_exit(void) remove_proc_entry("sputrace", NULL); kfree(sputrace_log); + marker_synchronize_unregister(); } module_init(sputrace_init); -- Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] sputrace : use marker_synchronize_unregister() 2008-09-29 15:11 ` [PATCH] sputrace : use marker_synchronize_unregister() Mathieu Desnoyers @ 2008-09-29 15:13 ` Christoph Hellwig 2008-09-30 0:28 ` Jeremy Kerr 1 sibling, 0 replies; 7+ messages in thread From: Christoph Hellwig @ 2008-09-29 15:13 UTC (permalink / raw) To: Mathieu Desnoyers Cc: Lai Jiangshan, Linux Kernel Mailing List, Steven Rostedt, Christoph Hellwig, linuxppc-dev, Jeremy Kerr, Ingo Molnar, Paul E. McKenney, Andrew Morton, Peter Zijlstra On Mon, Sep 29, 2008 at 11:11:47AM -0400, Mathieu Desnoyers wrote: > We need a marker_synchronize_unregister() before the end of exit() to make sure > every probe callers have exited the non preemptible section and thus are not > executing the probe code anymore. Looks good. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] sputrace : use marker_synchronize_unregister() 2008-09-29 15:11 ` [PATCH] sputrace : use marker_synchronize_unregister() Mathieu Desnoyers 2008-09-29 15:13 ` Christoph Hellwig @ 2008-09-30 0:28 ` Jeremy Kerr 2008-09-30 9:55 ` Ingo Molnar 1 sibling, 1 reply; 7+ messages in thread From: Jeremy Kerr @ 2008-09-30 0:28 UTC (permalink / raw) To: Mathieu Desnoyers Cc: Lai Jiangshan, Linux Kernel Mailing List, Steven Rostedt, cbe-oss-dev, Christoph Hellwig, linuxppc-dev, Ingo Molnar, Paul E. McKenney, Andrew Morton, Peter Zijlstra Mathieu, > We need a marker_synchronize_unregister() before the end of exit() to > make sure every probe callers have exited the non preemptible section > and thus are not executing the probe code anymore. Looks good - added to spufs.git. Cheers, Jeremy ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] sputrace : use marker_synchronize_unregister() 2008-09-30 0:28 ` Jeremy Kerr @ 2008-09-30 9:55 ` Ingo Molnar 2008-09-30 11:22 ` [Cbe-oss-dev] " Jeremy Kerr 0 siblings, 1 reply; 7+ messages in thread From: Ingo Molnar @ 2008-09-30 9:55 UTC (permalink / raw) To: Jeremy Kerr Cc: Mathieu Desnoyers, Lai Jiangshan, Linux Kernel Mailing List, Steven Rostedt, Christoph Hellwig, linuxppc-dev, Andrew Morton, Paul E. McKenney, cbe-oss-dev, Peter Zijlstra * Jeremy Kerr <jk@ozlabs.org> wrote: > Mathieu, > > > We need a marker_synchronize_unregister() before the end of exit() to > > make sure every probe callers have exited the non preemptible section > > and thus are not executing the probe code anymore. > > Looks good - added to spufs.git. that wont work very well as the patch relies on the new marker_synchronize_unregister() facility. Ingo ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Cbe-oss-dev] [PATCH] sputrace : use marker_synchronize_unregister() 2008-09-30 9:55 ` Ingo Molnar @ 2008-09-30 11:22 ` Jeremy Kerr 2008-09-30 11:30 ` Ingo Molnar 0 siblings, 1 reply; 7+ messages in thread From: Jeremy Kerr @ 2008-09-30 11:22 UTC (permalink / raw) To: cbe-oss-dev Cc: Mathieu Desnoyers, Lai Jiangshan, Linux Kernel Mailing List, Steven Rostedt, Christoph Hellwig, linuxppc-dev, Ingo Molnar, Paul E. McKenney, Andrew Morton, Peter Zijlstra Ingo, > that wont work very well as the patch relies on the new > marker_synchronize_unregister() facility. d'oh, right you are. Should I leave this in your hands to merge? Cheers, Jeremy ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Cbe-oss-dev] [PATCH] sputrace : use marker_synchronize_unregister() 2008-09-30 11:22 ` [Cbe-oss-dev] " Jeremy Kerr @ 2008-09-30 11:30 ` Ingo Molnar 2008-09-30 11:34 ` Jeremy Kerr 0 siblings, 1 reply; 7+ messages in thread From: Ingo Molnar @ 2008-09-30 11:30 UTC (permalink / raw) To: Jeremy Kerr Cc: Mathieu Desnoyers, Lai Jiangshan, Linux Kernel Mailing List, Steven Rostedt, Christoph Hellwig, linuxppc-dev, Andrew Morton, Paul E. McKenney, cbe-oss-dev, Peter Zijlstra * Jeremy Kerr <jk@ozlabs.org> wrote: > Ingo, > > > that wont work very well as the patch relies on the new > > marker_synchronize_unregister() facility. > > d'oh, right you are. Should I leave this in your hands to merge? would be nice if you could give your Acked-by for the sputrace bits, then we can merge it. It's a oneliner so it shouldnt cause merging trouble in linux-next. Ingo ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Cbe-oss-dev] [PATCH] sputrace : use marker_synchronize_unregister() 2008-09-30 11:30 ` Ingo Molnar @ 2008-09-30 11:34 ` Jeremy Kerr 0 siblings, 0 replies; 7+ messages in thread From: Jeremy Kerr @ 2008-09-30 11:34 UTC (permalink / raw) To: Ingo Molnar Cc: Mathieu Desnoyers, Lai Jiangshan, Linux Kernel Mailing List, Steven Rostedt, Christoph Hellwig, linuxppc-dev, Andrew Morton, Paul E. McKenney, cbe-oss-dev, Peter Zijlstra Ingo, > would be nice if you could give your Acked-by for the sputrace bits, > then we can merge it. It's a oneliner so it shouldnt cause merging > trouble in linux-next. Sure! Acked-by: Jeremy Kerr <jk@ozlabs.org> Jeremy ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2008-09-30 11:34 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <48E08B05.7030802@cn.fujitsu.com>
[not found] ` <20080929082722.GB18663@elte.hu>
2008-09-29 15:11 ` [PATCH] sputrace : use marker_synchronize_unregister() Mathieu Desnoyers
2008-09-29 15:13 ` Christoph Hellwig
2008-09-30 0:28 ` Jeremy Kerr
2008-09-30 9:55 ` Ingo Molnar
2008-09-30 11:22 ` [Cbe-oss-dev] " Jeremy Kerr
2008-09-30 11:30 ` Ingo Molnar
2008-09-30 11:34 ` Jeremy Kerr
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).