From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from buildserver.ru.mvista.com (unknown [85.21.88.6]) by ozlabs.org (Postfix) with ESMTP id A000ADDED5 for ; Fri, 3 Oct 2008 18:48:51 +1000 (EST) Date: Fri, 3 Oct 2008 12:48:49 +0400 From: Anton Vorontsov To: Kumar Gala Subject: Re: [PATCH] powerpc: make Freescale QE support a selectable Kconfig option Message-ID: <20081003084849.GA18271@oksana.dev.rtsoft.ru> References: <1222961277-6166-1-git-send-email-timur@freescale.com> <20081003070416.GA460@oksana.dev.rtsoft.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1251 In-Reply-To: Cc: linuxppc-dev@ozlabs.org, Timur Tabi Reply-To: avorontsov@ru.mvista.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Oct 03, 2008 at 02:58:57AM -0500, Kumar Gala wrote: > > On Oct 3, 2008, at 2:04 AM, Anton Vorontsov wrote: > >> On Thu, Oct 02, 2008 at 10:27:57AM -0500, Timur Tabi wrote: >>> Modify the Kconfig so that Freescale QUICC Engine (QE) support is a >>> selectable >>> option, thereby allowing users to compile kernels without any QE >>> support. >>> >>> The drawback is that QE support is now disabled by default on >>> platforms that >>> have a QE, and so a defconfig is needed to enable QE and QE devices >>> (like >>> UCC GETH). Fortunately, all the current relevant defconfigs do that >>> already. >>> >>> Signed-off-by: Timur Tabi >>> --- >> >> [...] >>> config MPC836x_RDK >>> bool "Freescale/Logic MPC836x RDK" >>> select DEFAULT_UIMAGE >>> - select QUICC_ENGINE >>> select QE_GPIO >> >> IIRC selects do not honor any dependencies, i.e. you should delete >> the QE_GPIO too. > > Is QE_GPIO need by the board? or you just enabled it to have it? Well... This select is a relic from the time when we were discussing how to register QE GPIOs: using board files or using a dedicated arch_initcall. We seemed to agree on arch_initcall, but in the end you applied 'board file' approach. ;-) http://www.mail-archive.com/linuxppc-dev@ozlabs.org/msg19147.html Later I sent you an update that eliminated the need of the QE_GPIO select: http://www.mail-archive.com/linuxppc-dev@ozlabs.org/msg19147.html But nobody recalled to remove the 'select QE_GPIO' after that... -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2