linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Timur Tabi <timur@freescale.com>
Subject: [PATCH] powerpc/QE: move QE_GPIO Kconfig symbol into the platforms/Kconfig
Date: Fri, 3 Oct 2008 23:40:36 +0400	[thread overview]
Message-ID: <20081003194036.GA9323@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <B88B23CE-9EBD-4C4B-9978-0E9C3C3AB738@kernel.crashing.org>

Specifying user-selectable option in the qe_lib/Kconfig was a bad idea
because the qe_lib/Kconfig is included into the top level Kconfig, and
thus the QE_GPIO option appears at the top level menu.

This patch effectively moves the QE_GPIO option under the platform menu
instead.

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---

On Fri, Oct 03, 2008 at 12:48:31PM -0500, Kumar Gala wrote:
[...]
> I want to leave the "hidden" options in qe_lib/Kconfig.. just move the  
> user selectable one (QE_GPIO) in to platforms/Kconfig

Here it is.

 arch/powerpc/platforms/Kconfig     |    9 +++++++++
 arch/powerpc/sysdev/qe_lib/Kconfig |    9 ---------
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/arch/powerpc/platforms/Kconfig b/arch/powerpc/platforms/Kconfig
index 8871185..71845d7 100644
--- a/arch/powerpc/platforms/Kconfig
+++ b/arch/powerpc/platforms/Kconfig
@@ -249,6 +249,15 @@ config QUICC_ENGINE
 	  Selecting this option means that you wish to build a kernel
 	  for a machine with a QE coprocessor.
 
+config QE_GPIO
+	bool "QE GPIO support"
+	depends on QUICC_ENGINE
+	select GENERIC_GPIO
+	select ARCH_REQUIRE_GPIOLIB
+	help
+	  Say Y here if you're going to use hardware that connects to the
+	  QE GPIOs.
+
 config CPM2
 	bool "Enable support for the CPM2 (Communications Processor Module)"
 	depends on MPC85xx || 8260
diff --git a/arch/powerpc/sysdev/qe_lib/Kconfig b/arch/powerpc/sysdev/qe_lib/Kconfig
index 1ce5464..76ffbc4 100644
--- a/arch/powerpc/sysdev/qe_lib/Kconfig
+++ b/arch/powerpc/sysdev/qe_lib/Kconfig
@@ -24,12 +24,3 @@ config QE_USB
 	bool
 	help
 	  QE USB Host Controller support
-
-config QE_GPIO
-	bool "QE GPIO support"
-	depends on QUICC_ENGINE
-	select GENERIC_GPIO
-	select ARCH_REQUIRE_GPIOLIB
-	help
-	  Say Y here if you're going to use hardware that connects to the
-	  QE GPIOs.
-- 
1.5.6.3

  reply	other threads:[~2008-10-03 19:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-02 15:27 [PATCH] powerpc: make Freescale QE support a selectable Kconfig option Timur Tabi
2008-10-03  5:12 ` Kumar Gala
2008-10-03  7:04 ` Anton Vorontsov
2008-10-03  7:58   ` Kumar Gala
2008-10-03  8:48     ` Anton Vorontsov
2008-10-03  9:08       ` Anton Vorontsov
2008-10-03 15:43         ` Timur Tabi
2008-10-03 16:05           ` Anton Vorontsov
2008-10-03 16:09             ` Timur Tabi
2008-10-03 16:18               ` Kumar Gala
2008-10-03 16:23               ` Anton Vorontsov
2008-10-03 16:54                 ` Timur Tabi
2008-10-03 17:48                 ` Kumar Gala
2008-10-03 19:40                   ` Anton Vorontsov [this message]
2008-10-03 21:55                     ` [PATCH] powerpc/QE: move QE_GPIO Kconfig symbol into the platforms/Kconfig Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081003194036.GA9323@oksana.dev.rtsoft.ru \
    --to=avorontsov@ru.mvista.com \
    --cc=galak@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=timur@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).