From: Dave Jones <davej@redhat.com>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: linuxppc-dev@ozlabs.org, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: fsl_upm compile failure.
Date: Wed, 8 Oct 2008 19:33:06 -0400 [thread overview]
Message-ID: <20081008233306.GA31771@redhat.com> (raw)
In-Reply-To: <20081008230219.GA8075@oksana.dev.rtsoft.ru>
On Thu, Oct 09, 2008 at 03:02:19AM +0400, Anton Vorontsov wrote:
> Hi,
>
> On Wed, Oct 08, 2008 at 06:28:15PM -0400, Dave Jones wrote:
> > Hi Anton,
> > I tried reenabling CONFIG_MTD_NAND_FSL_UPM in the Fedora kernel
> > today (currently on 2.6.27-rc9-git1), and got the error below.
> >
> > ERROR: "fsl_lbc_lock" [drivers/mtd/nand/fsl_upm.ko] undefined!
>
> Weird. It works for me with mpc836x_rdk_defconfig and
> MTD_NAND_FSL_UPM=m...
>
> Hm..
>
> CC drivers/mtd/nand/fsl_upm.mod.o
> LD [M] drivers/mtd/nand/fsl_upm.ko
>
> Can you send me the .config file you use?
http://davej.fedorapeople.org/ppc.config
> But the patch looks obviously correct. Much thanks for catching this.
>
> Though better option would be to uninline the fsl_upm_run_pattern()..
> it is quite big anyway... Something like this:
I'll leave it to you to decide what to push to Linus
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2008-10-08 23:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081008222815.GA20542@redhat.com>
2008-10-08 23:02 ` fsl_upm compile failure Anton Vorontsov
2008-10-08 23:17 ` Anton Vorontsov
2008-10-08 23:33 ` Dave Jones [this message]
2008-10-09 0:32 ` [PATCH] powerpc: fix fsl_upm nand driver modular build Anton Vorontsov
2008-10-13 16:48 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081008233306.GA31771@redhat.com \
--to=davej@redhat.com \
--cc=avorontsov@ru.mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).