Hi Martyn,

On Mon, 13 Oct 2008 09:53:49 +0100 Martyn Welch <martyn.welch@gefanuc.com> wrote:
>
> --- a/arch/powerpc/platforms/86xx/gef_sbc610.c
> +++ b/arch/powerpc/platforms/86xx/gef_sbc610.c
> @@ -73,6 +73,7 @@ static void __init gef_sbc610_init_irq(void)
>  
>  static void __init gef_sbc610_setup_arch(void)
>  {
> +	struct device_node *regs;
>  #ifdef CONFIG_PCI
>  	struct device_node *np;
>  
> @@ -86,8 +87,42 @@ static void __init gef_sbc610_setup_arch(void)
>  #ifdef CONFIG_SMP
>  	mpc86xx_smp_init();
>  #endif
> +
> +	/* Remap basic board registers */
> +	regs = of_find_compatible_node(NULL, NULL, "gef,fpga-regs");
> +	if (regs) {
> +		sbc610_regs = of_iomap(regs, 0);
> +		if (sbc610_regs == NULL)
> +			printk(KERN_WARNING "Unable to map board registers\n");

You need an of_node_put(regs) here.

> +	}
> +}
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/