From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/2] powerpc/83xx: add DS1339 RTC support for MPC8349E-mITX boards
Date: Tue, 21 Oct 2008 22:41:09 +0400 [thread overview]
Message-ID: <20081021184109.GA25590@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20081021182344.GA22232@ld0162-tx32.am.freescale.net>
On Tue, Oct 21, 2008 at 01:23:44PM -0500, Scott Wood wrote:
> On Fri, Oct 17, 2008 at 10:56:59PM +0400, Anton Vorontsov wrote:
> > diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/boot/dts/mpc8349emitx.dts
> > index 5cedf37..7fc5414 100644
> > --- a/arch/powerpc/boot/dts/mpc8349emitx.dts
> > +++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
> > @@ -83,6 +83,14 @@
> > interrupts = <15 0x8>;
> > interrupt-parent = <&ipic>;
> > dfsrr;
> > +
> > + rtc@68 {
> > + device_type = "rtc";
> > + compatible = "dallas,ds1339";
> > + reg = <0x68>;
> > + interrupts = <18 0x8>;
> > + interrupt-parent = <&ipic>;
> > + };
>
> Why are we adding more device_types?
It seems that CHRP is using the device_type for rtc devices, which
means that real OF also provide it. But I guess we don't need it,
right? Then we should cleanup all the boards.
prev parent reply other threads:[~2008-10-21 18:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-17 18:56 [PATCH 1/2] powerpc/83xx: add DS1339 RTC support for MPC8349E-mITX boards Anton Vorontsov
2008-10-21 4:39 ` Kumar Gala
2008-10-21 18:23 ` Scott Wood
2008-10-21 18:35 ` Kumar Gala
2008-10-21 18:39 ` Scott Wood
2008-10-21 18:41 ` Anton Vorontsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081021184109.GA25590@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).