From: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org,
Hendrik Brueckner <brueckner@linux.vnet.ibm.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
ppc-dev <linuxppc-dev@ozlabs.org>
Subject: Re: linux-next: ttydev tree build failure
Date: Thu, 23 Oct 2008 12:28:05 +0200 [thread overview]
Message-ID: <20081023102805.GA4197@cetus.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20081023172938.0460b191.sfr@canb.auug.org.au>
On Thu, Oct 23, 2008 at 05:29:38PM +1100, Stephen Rothwell wrote:
> drivers/char/hvc_console.c: In function 'hvc_set_winsz':
> drivers/char/hvc_console.c:532: warning: passing argument 2 of 'tty_do_resize' from incompatible pointer type
> drivers/char/hvc_console.c:532: error: too many arguments to function 'tty_do_resize'
>
> Caused by commit eb6ab2d361a49470ca9785c70482772c19e49bec
> ("pty-simplify-resize") from the ttydev tree interacting with commit
> febde3711992a64ea83a47a719f68a90c4b0927a ("hvc_console: Add support for
> tty window resizing").
>
> The former added another call to the function that the latter changed.
In linux-next, the pty-simplify-resize patch has changed the
tty_do_resize() signature; and therefore the hvc patch did not compile.
> I applied the following patch.
The patch is correct.
Thanks.
Acked-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
--
Regards
Hendrik
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschaeftsfuehrung: Erich Baier
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
prev parent reply other threads:[~2008-10-23 10:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-23 6:29 linux-next: ttydev tree build failure Stephen Rothwell
2008-10-23 7:34 ` Alan Cox
2008-10-23 7:35 ` Benjamin Herrenschmidt
2008-10-24 4:58 ` Stephen Rothwell
2008-10-23 10:28 ` Hendrik Brueckner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081023102805.GA4197@cetus.boeblingen.de.ibm.com \
--to=brueckner@linux.vnet.ibm.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).