From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: odd change to drivers/net/ibm_newemac/core.c
Date: Thu, 23 Oct 2008 17:46:06 -0400 [thread overview]
Message-ID: <20081023174606.555a65de@zod.rchland.ibm.com> (raw)
In-Reply-To: <20081023214148.GA32322@lst.de>
On Thu, 23 Oct 2008 23:41:48 +0200
Christoph Hellwig <hch@lst.de> wrote:
> +#ifdef CONFIG_IBM_NEW_EMAC_NO_FLOW_CONTROL
> dev->features |= EMAC_FTR_NO_FLOW_CONTROL_40x;
> +#else
> + printk(KERN_ERR "%s: Flow control not disabled!\n",
> + np->full_name);
> + return -ENXIO;
> +#endif
>
> What's this trying to do? CONFIG_IBM_NEW_EMAC_NO_FLOW_CONTROL doesn't
> exist anywhere, and it seems like an extremly strange idea for a config
Damnit. Typo. Should be CONFIG_IBM_NEW_EMAC_NO_FLOW_CTRL. It's right
elsewhere, I just fat-fingered the option with this particular change
because I was rushing for a build fix. I'll fix it with the brown
paper bag of shame over my head shortly.
> option. And "Flow control not disabled" is not an extremly useful error
> message for users either..
Normal users aren't supposed to set it. The option is selected by the
4xx platform config options on boards that need the feature. This is
how other things are done in the EMAC driver.
josh
prev parent reply other threads:[~2008-10-23 21:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-23 21:41 odd change to drivers/net/ibm_newemac/core.c Christoph Hellwig
2008-10-23 21:46 ` Josh Boyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081023174606.555a65de@zod.rchland.ibm.com \
--to=jwboyer@linux.vnet.ibm.com \
--cc=hch@lst.de \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).